fix(cloudformation): add error message to import resource state failure#8632
Open
gemammercado wants to merge 7 commits intoaws:masterfrom
Open
fix(cloudformation): add error message to import resource state failure#8632gemammercado wants to merge 7 commits intoaws:masterfrom
gemammercado wants to merge 7 commits intoaws:masterfrom
Conversation
|
atennak1
reviewed
Mar 2, 2026
gemammercado
force-pushed
the
fix/resource-import-failure-reasons
branch
from
cae2540 to
0d54673
Compare
gemammercado
force-pushed
the
fix/resource-import-failure-reasons
branch
2 times, most recently
from
14ac123 to
741c00b
Compare
gemammercado
force-pushed
the
fix/resource-import-failure-reasons
branch
from
741c00b to
89e894e
Compare
Zee2413
reviewed
Apr 30, 2026
| reasons.push(`[${id}: ${reason}]`) | ||
| } | ||
| } | ||
| return reasons.length > 0 ? `: ${reasons.join(', ')}` : '' |
Contributor
There was a problem hiding this comment.
Does this render nicely if there is a lot of errors?
Should we set a limit?
Does the notification show up collapsed after the first part?
Zee2413
approved these changes
Apr 30, 2026
satyakigh
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When a resource fails to import, the error message displayed to the user is currently just 'Failed'. Not useful for debugging.
Solution:
Display the AWS error message that includes the actual failure reason(s).
feature/xbranches will not be squash-merged at release time.