toolkit#8696
Closed
LOve-luST-LOST wants to merge 5 commits intoaws:masterfrom
Closed
Conversation
Add a non-root user to the Dockerfile to prevent container processes from running as root. ## Changes - Create a dedicated `appuser` account with `useradd` - Set ownership of `/code` directory to the new user - Add `USER appuser` directive before CMD - Remove `--unsafe-perm` flag from npm install (no longer needed for non-root user) ## Why Running containers as root is a security risk. If an attacker gains control of a process running as root, they potentially have full control over the container. By switching to a non-root user, we limit the blast radius of any potential container compromise. ## Semgrep Finding Details By not specifying a USER, a program in the container may run as 'root'. This is a security hazard. If an attacker can control a process running as root, they may have control over the container. Ensure that the last USER in a Dockerfile is a USER other than 'root'. @230243296 requested Semgrep Assistant generate this pull request to fix [a finding](https://semgrep.dev/orgs/alicefosseneuve_personal_org/findings/735185002) from the detection rule [dockerfile.security.missing-user.missing-user](https://semgrep.dev/r/dockerfile.security.missing-user.missing-user).
fix(docker): Add non-root user to Dockerfile for security
Added a security policy document outlining supported versions and vulnerability reporting.
Create SECURITY.md for security policy and reporting
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.