Clarify file-based credential flow direction in README#230
Merged
Conversation
Address reviewer feedback: make it explicit that the file-based credential provider supplies credentials TO the AWS SDK (not the other way around), since this is an inversion of the typical model where the SDK resolves credentials on its own. Changes: - Add credential flow diagram (disk → provider → SDK → SM) - Explain this is an alternative to the SDK's default resolution - Clarify the SDK callback model for the 10-minute expiry - Expand session token gate description with more context
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 34 34
Lines 9331 9331
Branches 9331 9331
=======================================
Hits 8028 8028
Misses 1170 1170
Partials 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
reyhankoyun
added
the
safe-to-test
github-actions
Bot
removed
the
safe-to-test
vedant-jaiswal
approved these changes
Jun 30, 2026
simonmarty
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies that the file-based credential provider supplies credentials to the AWS SDK, rather than consuming them. This is an inversion of the typical model where the SDK resolves credentials on its own, and customers found the previous wording ambiguous.