Skip to content

Commit 147108c

Browse files
committed
fix(strands-memory): restore positional arg order in AgentCoreMemorySessionManager.__init__
PR #288 inserted `converter` as the 2nd positional parameter, shifting `region_name` from position 2 to 3. Any caller passing region_name positionally (e.g. `AgentCoreMemorySessionManager(config, REGION)`) silently assigned the region string to `converter`, leaving region_name=None and causing botocore.exceptions.NoRegionError. Move `converter` after the existing positional params and make it keyword-only (after `*`) to restore backward compatibility and prevent future positional misuse.
1 parent a77f13a commit 147108c

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,22 +104,23 @@ def _get_monotonic_timestamp(cls, desired_timestamp: Optional[datetime] = None)
104104
def __init__(
105105
self,
106106
agentcore_memory_config: AgentCoreMemoryConfig,
107-
converter: Optional[type[MemoryConverter]] = None,
108107
region_name: Optional[str] = None,
109108
boto_session: Optional[boto3.Session] = None,
110109
boto_client_config: Optional[BotocoreConfig] = None,
110+
*,
111+
converter: Optional[type[MemoryConverter]] = None,
111112
**kwargs: Any,
112113
):
113114
"""Initialize AgentCoreMemorySessionManager with Bedrock AgentCore Memory.
114115
115116
Args:
116117
agentcore_memory_config (AgentCoreMemoryConfig): Configuration for AgentCore Memory integration.
117-
converter (Optional[type[MemoryConverter]], optional): Optional custom converter.
118-
If None, native Bedrock/Strands converter is used.
119118
region_name (Optional[str], optional): AWS region for Bedrock AgentCore Memory. Defaults to None.
120119
boto_session (Optional[boto3.Session], optional): Optional boto3 session. Defaults to None.
121120
boto_client_config (Optional[BotocoreConfig], optional): Optional boto3 client configuration.
122121
Defaults to None.
122+
converter (Optional[type[MemoryConverter]], optional): Optional custom converter.
123+
If None, native Bedrock/Strands converter is used.
123124
**kwargs (Any): Additional keyword arguments.
124125
"""
125126
self.converter = converter or AgentCoreMemoryConverter

0 commit comments

Comments
 (0)