fix: use memoryStrategyId instead of strategyId in search_long_term_memories#314
Merged
Conversation
…emories The boto3 retrieve_memory_records API requires memoryStrategyId in searchCriteria, but MemorySessionManager was sending strategyId, causing a parameter validation error. Fixes #303
tejaskash
had a problem deploying
to
auto-approve
GitHub Actions
Failure
jariy17
approved these changes
Mar 10, 2026
jariy17
left a comment
jariy17
left a comment
Contributor
There was a problem hiding this comment.
According to this document: https://docs.aws.amazon.com/boto3/latest/reference/services/bedrock-agentcore/client/retrieve_memory_records.html, it should memoryStrategyId
Hweinstock
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemorySessionManager.search_long_term_memoriessendingstrategyIdinstead ofmemoryStrategyIdin the search criteria passed to the boto3retrieve_memory_recordsAPI, which requiresmemoryStrategyId.Closes #303
Test plan
test_search_long_term_memories_with_strategyverifiesmemoryStrategyIdis senttest_search_long_term_memories_without_strategy_idverifies key is absent when not provided