Skip to content

fix: use memoryStrategyId instead of strategyId in search_long_term_memories #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tejaskash merged 1 commit into from
Mar 11, 2026
Merged

fix: use memoryStrategyId instead of strategyId in search_long_term_memories #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bedrock_agentcore/memory/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ def search_long_term_memories(
logger.info(" -> Querying long-term memory in namespace '%s' with query: '%s'...", namespace_prefix, query)
search_criteria = {"searchQuery": query, "topK": top_k}
if strategy_id:
search_criteria["strategyId"] = strategy_id
search_criteria["memoryStrategyId"] = strategy_id

namespace = namespace_prefix
params = {
Expand Down
4 changes: 2 additions & 2 deletions tests/bedrock_agentcore/memory/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,7 +1213,7 @@ def test_search_long_term_memories_with_strategy(self):

# Verify strategy_id was passed
call_args = mock_client_instance.retrieve_memory_records.call_args[1]
assert call_args["searchCriteria"]["strategyId"] == "strategy-123"
assert call_args["searchCriteria"]["memoryStrategyId"] == "strategy-123"

def test_search_long_term_memories_client_error(self):
"""Test search_long_term_memories with ClientError."""
Expand Down Expand Up @@ -2182,7 +2182,7 @@ def test_search_long_term_memories_without_strategy_id(self):

# Verify strategy_id was not passed
call_args = mock_client_instance.retrieve_memory_records.call_args[1]
assert "strategyId" not in call_args["searchCriteria"]
assert "memoryStrategyId" not in call_args["searchCriteria"]

def test_list_long_term_memory_records_without_strategy_id(self):
"""Test list_long_term_memory_records without strategy_id to cover missing branch."""
Expand Down
Loading