test(memory): add stream delivery integ tests, and TESTING.md#317
Merged
Conversation
Hweinstock
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
0ed3195 to
335f694
Compare
Hweinstock
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
335f694 to
98d31d8
Compare
Hweinstock
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
98d31d8 to
51e780b
Compare
Hweinstock
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
51e780b to
7a00b08
Compare
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
7a00b08 to
2ba6267
Compare
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
2 times, most recently
from
2492661 to
18c0d0a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage ? 90.87%
=======================================
Files ? 42
Lines ? 4033
Branches ? 618
=======================================
Hits ? 3665
Misses ? 202
Partials ? 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
6 times, most recently
from
0f91e7f to
668d524
Compare
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
3 times, most recently
from
3f43b1a to
a4de01f
Compare
Hweinstock
added a commit
to Hweinstock/bedrock-agentcore-sdk-python
that referenced
this pull request
Mar 11, 2026
Add update_memory to MemoryClient so developers no longer need to drop down to MemoryControlPlaneClient to update memory properties like description, event expiry, execution role, or stream delivery config. - Builds params dict with only provided fields (same pattern as create_memory) - Calls gmcp_client.update_memory and normalizes response - Removes update_memory from _ALLOWED_GMCP_METHODS (explicit method replaces forwarding) - Unit tests: param passthrough, normalization, omitted params, minimal params, ClientError - Integration test: builds on PR aws#317 TestStreamDeliveryResources class with test_stream_delivery_update (FULL_CONTENT -> METADATA_ONLY with wait/poll)
Hweinstock
added a commit
to Hweinstock/bedrock-agentcore-sdk-python
that referenced
this pull request
Mar 11, 2026
Add a focused method to update stream delivery configuration on a memory without requiring callers to drop down to MemoryControlPlaneClient. - Calls gmcp_client.update_memory with only memoryId, clientToken, and streamDeliveryResources — no other memory properties are modified - Normalizes response via _normalize_memory_response - Does not shadow the existing update_memory passthrough in _ALLOWED_GMCP_METHODS - Unit tests: config passthrough, response normalization, ClientError propagation - Integration test: builds on PR aws#317 TestStreamDeliveryResources with test_stream_delivery_update (FULL_CONTENT -> METADATA_ONLY with wait/poll)
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
3 times, most recently
from
b3df0db to
4218416
Compare
Contributor
Author
|
As discussed in person, going to adjust this PR by proposing a set of testing guidelines for future integ tests to help maintain consistency. |
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
2 times, most recently
from
682b8e1 to
23db03e
Compare
Hweinstock
force-pushed
the
feature/memory-integ-tests
branch
from
23db03e to
138d561
Compare
jariy17
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Problem
Memory integration tests have no documentation for running locally, and there is no test coverage for the streamDeliveryResources feature.
Solution
Testing
Note: it takes ~2-3 minutes due to memory provisioning delay.
Future Work
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.