fix: add missing agentId metadata to batched agent state flush#331
Merged
Hweinstock merged 1 commit intoMar 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage ? 90.85%
=======================================
Files ? 42
Lines ? 4046
Branches ? 624
=======================================
Hits ? 3676
Misses ? 203
Partials ? 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a119d16 to
ba7a5d4
Compare
ba7a5d4 to
933922e
Compare
padmak30
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Problem
The integ test is failing in CI defined here.
The test uses
batch_size=10so agent state is not sent immediately and is instead only sent by flushing on session closure. The code to send the state immediately includes theAGENT_ID:bedrock-agentcore-sdk-python/src/bedrock_agentcore/memory/integrations/strands/session_manager.py
Lines 319 to 331 in 18b428a
However, the code to flush the agent state does not include it:
bedrock-agentcore-sdk-python/src/bedrock_agentcore/memory/integrations/strands/session_manager.py
Lines 872 to 881 in 18b428a
This causes an issue when we try to read the session information back for that agent since we query on agentId being in the metadata.
bedrock-agentcore-sdk-python/src/bedrock_agentcore/memory/integrations/strands/session_manager.py
Lines 357 to 376 in 18b428a
Solution
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.