feat: add gateway client and tests by nborges-aws · Pull Request #428 · aws/bedrock-agentcore-sdk-python

nborges-aws · 2026-04-23T16:24:24Z

Issue #, if available: Issue #390

Description of changes:

Add GatewayClient with __getattr__ passthrough
Control plane allowlisted methods (16):
- Gateway CRUD: create_gateway, get_gateway, list_gateways, update_gateway, delete_gateway
- Gateway target CRUD: create_gateway_target, get_gateway_target, list_gateway_targets, update_gateway_target, delete_gateway_target
- Gateway rules: create_gateway_rule, get_gateway_rule, list_gateway_rules, update_gateway_rule, delete_gateway_rule
- Other: synchronize_gateway_targets
Add *_and_wait polling methods using shared wait_until/wait_until_deleted utilities:
- create_gateway_and_wait, update_gateway_and_wait, delete_gateway_and_wait
- create_gateway_target_and_wait, update_gateway_target_and_wait, delete_gateway_target_and_wait
Add name-based lookup methods with per-page pagination and early termination:
- get_gateway_by_name — paginates through gateways, returns full details on first match
- get_gateway_target_by_name — paginates through targets for a given gateway, returns full details on first match
All *_and_wait methods accept WaitConfig for configurable polling behavior and apply convert_kwargs for snake_case support

Test Plan:

Unit tests (11 total, all passing):
- Init: region, region fallback
- Passthrough: CP forwarding, snake_case conversion, AttributeError on unknown method
- Wait methods: create gateway, create gateway failed, create target, delete gateway
- Name lookup: found, not found
Integration tests (15 total):
- Gateway CRUD lifecycle: create+wait → get (camelCase + snake_case) → name lookup (found + not found) → list → update+wait → delete+wait
- Target CRUD lifecycle: create+wait → get → name lookup (found + not found) → list → update+wait → delete+wait

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions · 2026-04-23T16:24:40Z

✅ No Breaking Changes Detected

No public API breaking changes found in this PR.

Hweinstock

Looks good! Small qs about integ tests.

Hweinstock · 2026-04-23T20:15:55Z

+        cls.region = os.environ.get("BEDROCK_TEST_REGION", "us-west-2")
+        cls.role_arn = os.environ.get("GATEWAY_ROLE_ARN")
+        if not cls.role_arn:
+            pytest.skip("GATEWAY_ROLE_ARN not set")


could this lead to tests being silently skipped or would the CI action still fail?

Hweinstock · 2026-04-23T20:17:26Z

+            authorizerType="NONE",
+            description="updated by integ test",
+        )
+        assert updated["status"] == "READY"


should we assert that the gateway was actually updated?

yep I'll add same assertion that i did for policy to make sure its actually updated

Hweinstock · 2026-04-23T20:21:06Z

+                    )
+            if not response.get("nextToken"):
+                return None
+            kwargs["nextToken"] = response["nextToken"]


Two questions:

why would a user pass in nextToken?

should we use a local variable instead to avoid mutating the parameters?

Popping the nextToken was just a defensive guard to make sure if the user passed in a nextToken, it does not conflict with our internal pagination. Maybe not necessary but cheap and harmless imo

Good catch. I've changed this to a local var

Hweinstock · 2026-04-23T20:23:14Z

+
+
+@pytest.mark.integration
+class TestGatewayClient:


nit: could we add one more get_gateway_target_by_name

There's tests for get_gateway_target_by_name in the TestGatewayTargetClient class down below. Is there a specific case that you were thinking of missing?

get_gateway_target returns AccessDeniedException when called with a gateway ARN. Extract the gateway ID from the ARN for all target _and_wait polling methods. Also add missing credentialProviderConfigurations to the update_gateway_target integ test.

…ting kwargs

nborges-aws requested a review from a team April 23, 2026 16:24

nborges-aws had a problem deploying to auto-approve April 23, 2026 16:24 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 23, 2026 16:24 — with GitHub Actions Inactive

Hweinstock reviewed Apr 23, 2026

View reviewed changes

jesseturner21 temporarily deployed to auto-approve April 23, 2026 20:46 — with GitHub Actions Inactive

jesseturner21 had a problem deploying to auto-approve April 23, 2026 20:46 — with GitHub Actions Failure

jesseturner21 temporarily deployed to auto-approve April 23, 2026 20:46 — with GitHub Actions Inactive

jesseturner21 force-pushed the feat/gatewayClient branch from 22f7529 to cc85cfd Compare April 23, 2026 20:49

jesseturner21 temporarily deployed to auto-approve April 23, 2026 20:49 — with GitHub Actions Inactive

jesseturner21 had a problem deploying to auto-approve April 23, 2026 20:49 — with GitHub Actions Failure

nborges-aws had a problem deploying to auto-approve April 23, 2026 20:54 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 23, 2026 20:54 — with GitHub Actions Inactive

nborges-aws had a problem deploying to auto-approve April 23, 2026 21:09 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 23, 2026 21:09 — with GitHub Actions Inactive

nborges-aws temporarily deployed to auto-approve April 24, 2026 16:01 — with GitHub Actions Inactive

nborges-aws had a problem deploying to auto-approve April 24, 2026 16:01 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 24, 2026 16:01 — with GitHub Actions Inactive

Hweinstock previously approved these changes Apr 24, 2026

View reviewed changes

nborges-aws dismissed Hweinstock’s stale review via 7c77d2b April 24, 2026 16:32

nborges-aws had a problem deploying to auto-approve April 24, 2026 16:33 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 24, 2026 16:33 — with GitHub Actions Inactive

nborges-aws had a problem deploying to auto-approve April 24, 2026 16:33 — with GitHub Actions Failure

nborges-aws temporarily deployed to auto-approve April 24, 2026 16:33 — with GitHub Actions Inactive

Hweinstock approved these changes Apr 27, 2026

View reviewed changes

nborges-aws force-pushed the feat/gatewayClient branch from 7c77d2b to f71cad7 Compare April 27, 2026 17:19

nborges-aws temporarily deployed to auto-approve April 27, 2026 17:19 — with GitHub Actions Inactive

nborges-aws and others added 5 commits April 27, 2026 13:50

feat: add gateway client and tests

2ab8a2e

feat: add gateway client and tests

43c562c

fix: fail on missing params and assert against updated description

6ed9105

fix: change get_by_name methods to use local variable instead of muta…

ae1ff2e

…ting kwargs

nborges-aws force-pushed the feat/gatewayClient branch from f71cad7 to ae1ff2e Compare April 27, 2026 17:50

nborges-aws temporarily deployed to auto-approve April 27, 2026 17:50 — with GitHub Actions Inactive

nborges-aws merged commit 61677ba into main Apr 27, 2026
30 of 31 checks passed

nborges-aws deleted the feat/gatewayClient branch April 27, 2026 18:03

nborges-aws mentioned this pull request Apr 27, 2026

feat: Gateway Control Plane Client #390

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add gateway client and tests#428

feat: add gateway client and tests#428
nborges-aws merged 5 commits into
mainfrom
feat/gatewayClient

nborges-aws commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Hweinstock left a comment

Uh oh!

Hweinstock Apr 23, 2026

Uh oh!

Hweinstock Apr 23, 2026

Uh oh!

nborges-aws Apr 24, 2026

Uh oh!

Hweinstock Apr 23, 2026

Uh oh!

nborges-aws Apr 24, 2026

Uh oh!

Hweinstock Apr 23, 2026

Uh oh!

nborges-aws Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nborges-aws commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ No Breaking Changes Detected

Uh oh!

Hweinstock left a comment

Choose a reason for hiding this comment

Uh oh!

Hweinstock Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Hweinstock Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nborges-aws Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Hweinstock Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nborges-aws Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Hweinstock Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nborges-aws Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 23, 2026 •

edited

Loading