Skip to content

chore: test matrix for primitive clients and expose GH secrets to test env #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nborges-aws merged 1 commit into from
Apr 27, 2026
Merged

chore: test matrix for primitive clients and expose GH secrets to test env #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/integration-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,21 @@ jobs:
timeout: 5
extra-deps: ""
ignore: ""
- group: policy
path: tests_integ/policy
timeout: 15
extra-deps: ""

@Hweinstock Hweinstock Apr 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: are these required if they are just empty?

@nborges-aws nborges-aws Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the workflow steps uses ${{ matrix.extra-deps }} and ${{ matrix.ignore }}. I'm not sure if it would resolve to empty string on its own without including the blank fields in each matrix. I added the empty fields for consistency with existing matrices

ignore: ""
- group: gateway
path: tests_integ/gateway
timeout: 15
extra-deps: ""
ignore: ""
- group: identity
path: tests_integ/identity/test_identity_client.py
timeout: 15
extra-deps: ""
ignore: ""
steps:
- name: Configure Credentials
uses: aws-actions/configure-aws-credentials@v6
Expand Down Expand Up @@ -172,6 +187,15 @@ jobs:
MEMORY_PREPOPULATED_ID: ${{ secrets.MEMORY_PREPOPULATED_ID }}
RESOURCE_POLICY_TEST_ARN: ${{ secrets.RESOURCE_POLICY_TEST_ARN }}
RESOURCE_POLICY_TEST_PRINCIPAL: ${{ secrets.RESOURCE_POLICY_TEST_PRINCIPAL }}
GATEWAY_ROLE_ARN: ${{ secrets.GATEWAY_ROLE_ARN }}
GATEWAY_LAMBDA_ARN: ${{ secrets.GATEWAY_LAMBDA_ARN }}
EVAL_ROLE_ARN: ${{ secrets.EVAL_ROLE_ARN }}
EVAL_LOG_GROUP: ${{ secrets.EVAL_LOG_GROUP }}
RUNTIME_ROLE_ARN: ${{ secrets.RUNTIME_ROLE_ARN }}
RUNTIME_S3_CODE_URI: ${{ secrets.RUNTIME_S3_CODE_URI }}
COGNITO_POOL_ID: ${{ secrets.COGNITO_POOL_ID }}
COGNITO_CLIENT_ID: ${{ secrets.COGNITO_CLIENT_ID }}
COGNITO_CLIENT_SECRET: ${{ secrets.COGNITO_CLIENT_SECRET }}
id: tests
timeout-minutes: ${{ matrix.timeout }}
run: |
Expand Down
Loading