Skip to content

Xgboost migration - Add generate-release-spec and release-image steps to XGBoost SageMaker release workflow#5862

Merged
bhanutejagk merged 41 commits intomainfrom
xgboost-migration
Apr 9, 2026
Merged

Xgboost migration - Add generate-release-spec and release-image steps to XGBoost SageMaker release workflow#5862
bhanutejagk merged 41 commits intomainfrom
xgboost-migration

Conversation

@bhanutejagk
Copy link
Copy Markdown
Contributor

Purpose

Test Plan

Test Result


Toggle if you are merging into master Branch

By default, docker image builds and tests are disabled. Two ways to run builds and tests:

  1. Using dlc_developer_config.toml
  2. Using this PR description (currently only supported for PyTorch, TensorFlow, vllm, and base images)
How to use the helper utility for updating dlc_developer_config.toml

Assuming your remote is called origin (you can find out more with git remote -v)...

  • Run default builds and tests for a particular buildspec - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp origin

  • Enable specific tests for a buildspec or set of buildspecs - also commits and pushes changes to remote; Example:

python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp origin

  • Restore TOML file when ready to merge

python src/prepare_dlc_dev_environment.py -rcp origin

NOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:

  • sagemaker_remote_tests = true
  • sagemaker_efa_tests = true
  • sagemaker_rc_tests = true
  • sagemaker_local_tests = true
How to use PR description Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:
  • # /buildspec <buildspec_path>
    • e.g.: # /buildspec pytorch/training/buildspec.yml
    • If this line is commented out, dlc_developer_config.toml will be used.
  • # /tests <test_list>
    • e.g.: # /tests sanity security ec2
    • If this line is commented out, it will run the default set of tests (same as the defaults in dlc_developer_config.toml): sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.
# /buildspec <buildspec_path>
# /tests <test_list>
Toggle if you are merging into main Branch

PR Checklist

  • [] I ran pre-commit run --all-files locally before creating this PR. (Read DEVELOPMENT.md for details).

Bhanu Teja Goshikonda added 2 commits March 31, 2026 17:34
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 12
X-AI-Prompt: add these lines in release-sagemaker-xgboost to truigger # TODO: Remove push trigger after testing, keep only workflow_dispatch
push:
branches: [xgboost-release]
feat: Add push trigger on xgboost-release branch for release testing

Add a temporary push trigger on the xgboost-release branch to the
release workflow so it can be tested end-to-end without manual
workflow_dispatch. This trigger should be removed after testing.

ai-dev-branch commit IDs: 4f856af
The prompts used are captured in the footers of those commits.
The initial prompt was: add these lines in release-sagemaker-xgboost to truigger # TODO: Remove push trigger after testing, keep only workflow_dispatch

---
X-AI-Handle-Time-Seconds: 12
X-AI-Line-Changes: New:3, Altered:0, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:3, Altered:0, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 12
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci Bot added the Size:XS Determines the size of the PR label Apr 1, 2026
Bhanu Teja Goshikonda added 4 commits March 31, 2026 17:37
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 53
X-AI-Prompt: no this has made a mess now the pr contains only that changes of 2 lines
feat: Add release pipeline for XGBoost SageMaker gamma testing

Add generate-release-spec and release-image jobs to the XGBoost
SageMaker release workflow, modeled after the vLLM auto-release
workflow. The generate-release-spec job gates on unit-test and
security-test, checks if release is enabled in config, then
generates the release spec. The release-image job calls the
reusable-release-image workflow with the environment from config.

Benchmark tests are commented out since they already passed in
PR #5852. Also set public_registry to false since xgboost uses
private ECR only.

ai-dev-branch commit IDs: bd34e9a
The prompts used are captured in the footers of those commits.
The initial prompt was: no this has made a mess now the pr contains only that changes of 2 lines

---
X-AI-Handle-Time-Seconds: 53
X-AI-Line-Changes: New:41, Altered:38, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:41, Altered:38, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 53
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 14
X-AI-Prompt: okay make chagne to xgbost-migration brnach not release since our branch is migration not release
fix: Change release workflow push trigger branch to xgboost-migration

Update the push trigger branch from xgboost-release to
xgboost-migration to match the actual development branch name,
so the release workflow triggers on push to the correct branch.

ai-dev-branch commit IDs: c7c958a
The prompts used are captured in the footers of those commits.
The initial prompt was: okay make chagne to xgbost-migration brnach not release since our branch is migration not release

---
X-AI-Handle-Time-Seconds: 14
X-AI-Line-Changes: New:0, Altered:1, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 14
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
Bhanu Teja Goshikonda added 2 commits April 1, 2026 14:47
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 9
X-AI-Prompt: yeah set it
chore: Set force_release true to bypass change control for gamma testing

Set force_release to true in sagemaker-xgboost config to bypass
the AWS ADVISORY change control block on us-northeast-1 which
is incorrectly blocking us-west-2 gamma releases.

ai-dev-branch commit IDs: 643f139
The prompts used are captured in the footers of those commits.
The initial prompt was: yeah set it

---
X-AI-Handle-Time-Seconds: 9
X-AI-Line-Changes: New:0, Altered:1, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 9
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
Bhanu Teja Goshikonda and others added 3 commits April 2, 2026 18:53
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 37
X-AI-Prompt: Do not remove anything our changes are to just add the release image and generate release spec and the rest should not be changed what is in the main. i know previously we commented out the benchmark teests but recent chnages in repo already handled that so now we have to just add last 2 steps without changeing any thing
feat: Merge main and add generate-release-spec and release-image jobs

Merge latest main into xgboost-migration and add the
generate-release-spec and release-image jobs to the release
workflow. All other changes from main are preserved as-is.

ai-dev-branch commit IDs: 48062a6
The prompts used are captured in the footers of those commits.
The initial prompt was: Do not remove anything our changes are to just add the release image and generate release spec and the rest should not be changed what is in the main.

---
X-AI-Handle-Time-Seconds: 37
X-AI-Line-Changes: New:1967, Altered:135, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:1967, Altered:135, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 37
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci Bot added the Size:S Determines the size of the PR label Apr 3, 2026
bhanutejagk and others added 3 commits April 3, 2026 17:27
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 33
X-AI-Prompt: i want to test just the release logic comment the tests which might take hours to run
chore: Comment out tests to isolate release logic testing

Comment out unit-test, security-test, and xgboost-tests jobs
to speed up release logic iteration. generate-release-spec now
depends only on load-config and build-image.

ai-dev-branch commit IDs: 2084b30
The prompts used are captured in the footers of those commits.
The initial prompt was: i want to test just the release logic comment the tests which might take hours to run

---
X-AI-Handle-Time-Seconds: 33
X-AI-Line-Changes: New:0, Altered:62, Deleted:2
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:62, Deleted:2
X-AI-Handle-Time-Seconds-Kiro-cli: 33
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
Bhanu Teja Goshikonda added 2 commits April 9, 2026 12:57
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 28
X-AI-Prompt: change env to gamma from production
chore: Switch environment to gamma

ai-dev-branch commit IDs: 02d06b7
The prompts used are captured in the footers of those commits.
The initial prompt was: change env to gamma from production

---
X-AI-Handle-Time-Seconds: 28
X-AI-Line-Changes: New:0, Altered:1, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 28
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
Bhanu Teja Goshikonda added 3 commits April 9, 2026 13:22
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 9
X-AI-Prompt: ok change the env to preprod
chore: Switch environment to preprod

ai-dev-branch commit IDs: c5f65ee
The prompts used are captured in the footers of those commits.
The initial prompt was: ok change the env to preprod

---
X-AI-Handle-Time-Seconds: 9
X-AI-Line-Changes: New:0, Altered:1, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 9
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
Bhanu Teja Goshikonda added 3 commits April 9, 2026 15:44
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 34
X-AI-Prompt: remove on push and revert force release
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 41
X-AI-Prompt: ok enable all the tests also
chore: Remove push trigger, revert force_release, re-enable all tests

- Remove push trigger, keep only workflow_dispatch
- Set force_release back to false
- Uncomment unit-test, security-test, xgboost-tests
- Restore generate-release-spec dependency on all tests

ai-dev-branch commit IDs: ec203ef
The prompts used are captured in the footers of those commits.
The initial prompt was: remove on push and revert force release

---
X-AI-Handle-Time-Seconds: 75
X-AI-Line-Changes: New:0, Altered:58, Deleted:4
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:58, Deleted:4
X-AI-Handle-Time-Seconds-Kiro-cli: 75
X-AI-Change-Count: 2
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 2
X-CR-Amendment: false
Comment thread .github/config/sagemaker-xgboost.yml
Bhanu Teja Goshikonda added 3 commits April 9, 2026 16:03
---
X-AI-Tool: Kiro-cli
X-AI-Handle-Time-Seconds: 12
X-AI-Prompt: also make release : false
chore: Disable release

Set release: false to skip release steps in workflow.

ai-dev-branch commit IDs: 7f01b4a
The prompts used are captured in the footers of those commits.
The initial prompt was: also make release : false

---
X-AI-Handle-Time-Seconds: 12
X-AI-Line-Changes: New:0, Altered:1, Deleted:0
X-Human-Line-Changes: New:0, Altered:0, Deleted:0
X-AI-Line-Changes-Kiro-cli: New:0, Altered:1, Deleted:0
X-AI-Handle-Time-Seconds-Kiro-cli: 12
X-AI-Change-Count: 1
X-Human-Change-Count: 0
X-AI-Change-Count-Kiro-cli: 1
X-CR-Amendment: false
@Jyothirmaikottu Jyothirmaikottu dismissed their stale review April 9, 2026 23:26

Changes made.

@bhanutejagk bhanutejagk merged commit 9513ddd into main Apr 9, 2026
11 checks passed
@junpuf junpuf deleted the xgboost-migration branch April 14, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authorized Size:L Size:S Determines the size of the PR Size:XL Determines the size of the PR Size:XS Determines the size of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants