Skip to content

fix(cluster-api): Use registryHost for registry mirror credential host#5543

Open
peirulu wants to merge 1 commit into
aws:mainfrom
peirulu:fix-br-registrymirror
Open

fix(cluster-api): Use registryHost for registry mirror credential host#5543
peirulu wants to merge 1 commit into
aws:mainfrom
peirulu:fix-br-registrymirror

Conversation

@peirulu

@peirulu peirulu commented Jul 1, 2026

Copy link
Copy Markdown
Member

Add RegistryMirrorCredentialHost field and registryHost helper to strip paths from registry endpoints when configuring container-registry credentials in Bottlerocket. This ensures the credential registry field uses only host:port rather than the full endpoint path.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add RegistryMirrorCredentialHost field and registryHost helper to strip
paths from registry endpoints when configuring container-registry
credentials in Bottlerocket. This ensures the credential registry field
uses only host:port rather than the full endpoint path.
@eks-distro-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rajeshvenkata for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2026
@eks-distro-bot

Copy link
Copy Markdown
Collaborator

@peirulu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cluster-api-tooling-presubmit f4c3aee link true /test cluster-api-tooling-presubmit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants