Fix order-dependent deletion for superset value lists (#260) - #263
Draft
Pybsama wants to merge 1 commit into
Draft
Fix order-dependent deletion for superset value lists (#260)#263Pybsama wants to merge 1 commit into
Pybsama wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #260
Description of changes:
Machine.deleteRulecould silently fail when the supplied rule contained asuperset of the stored values. Values within a field have OR semantics, but
the delete path reused a mutable candidate set across those alternatives and
also used an empty set to mean both "not initialized yet" and "no candidates
matched the preceding keys." The result depended on value order.
This change:
from preceding keys;
alternatives for the field.
The existing multi-NameState wildcard teardown guard remains unchanged.
Testing:
mvn -Dtest=MachineTest test: 91 tests passed.mvn verify: 772 tests passed; Checkstyle and SpotBugs reported no findings.Benchmark / Performance (for source code changes):
Environment:
Full comparison command:
The only full-run flag was
ANYTHING_BUT, 0.2 percentage points outside thescript's heuristic noise band. I repeated the whole
ANYTHING_BUTfamily with5 warmup and 15 measurement passes:
No matching-throughput regression was reproducible. This change only affects
rule deletion; the benchmark exercises event matching.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.