refactor: change allow-write to read-only

Author: Kyon Caldera

README.md

@@ -35,7 +35,7 @@ Add this to your MCP client configuration, replacing env variables to match the
 Optional arguments you can add:
 - `--service`: AWS service name for SigV4 signing (inferred from endpoint if not provided)
 - `--profile`: AWS profile to use (uses AWS_PROFILE environment variable if not provided)
-- `--allow-write`: Allow tools that require write permissions to be enabled (by default, only tools with the `readOnlyHint` annotation are enabled)
+- `--read-only`: Disable tools which require write permissions. (tools which DO NOT require write permissions are annotated `readOnlyHint`)
 
 NOTE: `remote-server-url` should be your remote mcp server's URL (including the `/mcp` part). `service-code` should be the service code for your own mcp service, such as `eks-mcp`.
 
@@ -58,7 +58,7 @@ Example with all options
         "<service-code>",
         "--profile",
         "default",
-        "--allow-write"
+        "--read-only"
       ]
     }
   }

aws_mcp_proxy/mcp_proxy_manager.py

@@ -23,15 +23,15 @@ class McpProxyManager:
 
     logger = logging.getLogger(__name__)
 
-    def __init__(self, target_mcp: FastMCP, allow_write: bool = False):
+    def __init__(self, target_mcp: FastMCP, read_only: bool = False):
         """Initialize the MCP Proxy Manager.
 
         Args:
             target_mcp: The target MCP server to add content to
-            allow_write: Whether to allow tools that require write permissions
+            read_only: Whether to allow tools that require write permissions
         """
         self.target_mcp = target_mcp
-        self.allow_write = allow_write
+        self.read_only = read_only
 
     async def add_proxy_content(self, proxy: FastMCP) -> None:
         """Add tools, resources, and prompts from proxy to MCP server.
@@ -68,7 +68,7 @@ async def _add_tools(self, proxy: FastMCP) -> None:
         for tool_name, tool in tools.items():
             # Check the tool annotations and disable if needed
             annotations = tool.annotations
-            if not self.allow_write:
+            if self.read_only:
                 # In readOnly mode, skip the tools with no readOnlyHint=True annotation
                 if annotations and not annotations.readOnlyHint or not annotations:
                     self.logger.info(f'Skipping tool {tool_name} needing write permissions')

aws_mcp_proxy/server.py

@@ -63,7 +63,7 @@ async def setup_mcp_mode(mcp: FastMCP, args) -> None:
     proxy = FastMCP.as_proxy(transport)
 
     # Use McpProxyManager to add proxy content
-    proxy_manager = McpProxyManager(mcp, args.allow_write)
+    proxy_manager = McpProxyManager(mcp, args.read_only)
     await proxy_manager.add_proxy_content(proxy)
 
 
@@ -81,7 +81,7 @@ def parse_args():
   aws-mcp-proxy --endpoint https://eks-mcp.us-west-2.api.aws --service eks-mcp --profile default
 
   # Run with write permissions enabled
-  aws-mcp-proxy --endpoint https://eks-mcp.us-west-2.api.aws --allow-write
+  aws-mcp-proxy --endpoint https://eks-mcp.us-west-2.api.aws --read-only
         """,
     )
 
@@ -102,9 +102,9 @@ def parse_args():
     )
 
     parser.add_argument(
-        '--allow-write',
+        '--read-only',
         action='store_true',
-        help='Allow tools that require write permissions to be enabled',
+        help='Disable tools which require write permissions',
     )
 
     parser.add_argument(