Setup issue management#10
Conversation
|
Thanks for this! |
wzxxing
left a comment
wzxxing
left a comment
There was a problem hiding this comment.
Looks really nice! Just had one comment.
| required: true | ||
|
|
||
| - type: input | ||
| id: server-version |
There was a problem hiding this comment.
Should this be the proxy version?
There was a problem hiding this comment.
Ah correct would be better to change that to proxy version or more generic just "version"
There was a problem hiding this comment.
just "version" sounds fine to me.
| attributes: | ||
| label: Server Version |
There was a problem hiding this comment.
What is this? Would it be the URL?
| @@ -0,0 +1,83 @@ | |||
| --- | |||
There was a problem hiding this comment.
We probably want to require submitters to verify there are no existing bug reports of the same bug. And if there are related but not the same ask them to reference them.
There was a problem hiding this comment.
Added, refer to lines 85-100
|
https://github.com/acmlau/aws-mcp-proxy/blob/acmlau/.github/ISSUE_TEMPLATE/bug_report.yml has an error. YAML syntax error: (): mapping values are not allowed in this context at line 89 column 71. Learn more about this error. |
| id: version | ||
| attributes: | ||
| label: Server Version | ||
| Release Version / Commit id |
There was a problem hiding this comment.
note that including commit ID requires some custom logic when we build and publish the package. Right now we do not have it, only version is available at the moment.
If you are interested it, you can check for some available options.
There was a problem hiding this comment.
Will keep it to Release version then
There was a problem hiding this comment.
@wzxxing
Thing is they could be running from source as well, so commit id is also useful imo
Co-authored-by: Leonardo Araneda Freccero <arangatang@users.noreply.github.com> Signed-off-by: Anna Lau <66322063+acmlau@users.noreply.github.com>
3 participants
Description of changes: