Make endpoint positional argument#12
Merged
Merged
Conversation
arangatang
reviewed
Sep 29, 2025
| ## Quickstart | ||
| ### Running local code | ||
| ``` | ||
| uv run src/aws_mcp_proxy/server.py --endpoint <your endpoint> |
|
|
||
| ```bash | ||
| uv run src/aws_mcp_proxy/server.py --endpoint <a sigv4 mcp> | ||
| uv run aws_mcp_proxy/server.py <a sigv4 mcp> |
Contributor
There was a problem hiding this comment.
Lets be consistent, either or (or maybe something even more descriptive?)
Contributor
Author
There was a problem hiding this comment.
What about <SigV4 MCP endpoint URL>?
| "args": [ | ||
| "--directory", | ||
| "/path/to/aws_mcp_proxy/src/aws_mcp_proxy", | ||
| "/path/to/aws_mcp_proxy", |
Contributor
There was a problem hiding this comment.
While correct, just realized we need documentation on how to run the package version as well. Probs for @wzxxing to add when packaging is added.
Comment on lines
+78
to
+84
| aws-mcp-proxy https://eks-mcp.us-west-2.api.aws | ||
|
|
||
| # Run with custom service and profile | ||
| aws-mcp-proxy --endpoint https://eks-mcp.us-west-2.api.aws --service eks-mcp --profile default | ||
| aws-mcp-proxy https://eks-mcp.us-west-2.api.aws --service eks-mcp --profile default | ||
|
|
||
| # Run with write permissions enabled | ||
| aws-mcp-proxy --endpoint https://eks-mcp.us-west-2.api.aws --allow-write | ||
| aws-mcp-proxy https://eks-mcp.us-west-2.api.aws --allow-write |
Contributor
There was a problem hiding this comment.
We will remove all mentions of eks soon. Not a blocker just an fyi.
Co-authored-by: Leonardo Araneda Freccero <arangatang@users.noreply.github.com> Signed-off-by: Anna Lau <66322063+acmlau@users.noreply.github.com>
Contributor
|
We discussed offline, Readme / texts need updated anyhow, so we will collate those changes in another PR. |
arangatang
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
--endpointfrom a required flag to a positional argumentREADME.mdandDEVELOPMENT.mdto reflect changesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.