refactor: change allow-write to read-only#14
Merged
Conversation
kyoncal
force-pushed
the
refactor/read-only
branch
from
97422ed to
1951e44
Compare
arangatang
reviewed
Sep 30, 2025
arangatang
left a comment
arangatang
left a comment
Contributor
There was a problem hiding this comment.
Maybe slight rephrasing? Not sure my suggestions are the best but do consider if we need more specificity?
kyoncal
force-pushed
the
refactor/read-only
branch
from
1951e44 to
b7b3d3f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kyoncal
force-pushed
the
refactor/read-only
branch
from
b7b3d3f to
f2767dd
Compare
wzxxing
reviewed
Sep 30, 2025
refactor: fix tests broken because of changing allowing-write to read-only docs: rephrasing to add specificity
kyoncal
force-pushed
the
refactor/read-only
branch
from
f2767dd to
5c0efc9
Compare
arangatang
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This keeps the default value
False, however, the default behavior is negated.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.