fix: do not raise errors. Let mcp sdk handle the http errors#66
Merged
Conversation
55853ef to
0905e9a
Compare
arangatang
approved these changes
Nov 3, 2025
a3cef91 to
01a4c70
Compare
PCManticore
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
As a MCP proxy, we should not handle the HTTP transport error for the MCP SDK. Remove the
raise_for_statuscall,User experience
No user experience should change after this change because the python mcp sdk already handles the errors by themselves.
Fix bug for deleting session because the mcp sdk calls
raise_for_statusafter some checking status code 404.If we raise the error in the httpx event hooks, the error would make deleting session fail.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
Please add details about how this change was tested.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.