fix(mcp_proxy_for_aws/utils.py): add override for bedrock-agentcore service name detection#79
Merged
Merged
Conversation
Contributor
Author
|
Should fix #78 |
kyoncal
previously approved these changes
Nov 6, 2025
harv-aws
reviewed
Nov 6, 2025
harv-aws
reviewed
Nov 6, 2025
harv-aws
left a comment
harv-aws
left a comment
Contributor
There was a problem hiding this comment.
Aligned on functionality. added a minor comment on test.
wzxxing
reviewed
Nov 7, 2025
wzxxing
requested changes
Nov 10, 2025
kyoncal
previously approved these changes
Nov 11, 2025
wzxxing
reviewed
Nov 11, 2025
…ervice name detection Fixes failures when connecting to an Agentcore service.
wzxxing
approved these changes
Nov 12, 2025
kyoncal
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failures when connecting to an Agentcore service.
Summary
Bedrock AgentCore url structure does not align to our current
--servicedetection regex. For now i'm adding an override if we realize we will need more overrides as time goes on we should re-evaluate the regex itself.Changes
Adding a check for
.bedrock-agentcore.in the url and using this as service if found.User experience
After fix users connecting to AgentCore can omit the
--serviceflag.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
Please add details about how this change was tested.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.