Skip to content

Commit 02c23fd

Browse files
committed
fix: Remove hardcoded lmi config name in ModelBuilder optimize
Replace hardcoded config_name='lmi' in ModelBuilder.optimize() with the model's dynamically resolved default config name. The JumpStart metadata for models like llama-3-1-8b-instruct no longer includes an 'lmi' config, causing ValueError during optimization. Also fix test_jumpstart_session_with_config_name to use the model's resolved config_name instead of hardcoding 'tgi', and update unit test assertions in test_js_builder.py accordingly.
1 parent 5b12a1d commit 02c23fd

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

src/sagemaker/serve/builder/model_builder.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1728,9 +1728,11 @@ def _model_builder_optimize_wrapper(
17281728
if self._is_jumpstart_model_id():
17291729
self.build(mode=self.mode, sagemaker_session=self.sagemaker_session)
17301730
if self.pysdk_model:
1731-
self.pysdk_model.set_deployment_config(
1732-
instance_type=instance_type, config_name="lmi"
1733-
)
1731+
config_name = self.pysdk_model.config_name
1732+
if config_name:
1733+
self.pysdk_model.set_deployment_config(
1734+
instance_type=instance_type, config_name=config_name
1735+
)
17341736
input_args = self._optimize_for_jumpstart(
17351737
output_path=output_path,
17361738
instance_type=instance_type,

tests/integ/sagemaker/jumpstart/model/test_jumpstart_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def test_jumpstart_session_with_config_name():
414414
pass
415415

416416
assert (
417-
"md/js_model_id#meta-textgeneration-llama-2-7b md/js_model_ver#* md/js_config#tgi"
417+
f"md/js_model_id#meta-textgeneration-llama-2-7b md/js_model_ver#* md/js_config#{model.config_name}"
418418
in mock_make_request.call_args[0][1]["headers"]["User-Agent"]
419419
)
420420

tests/unit/sagemaker/serve/builder/test_js_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1696,7 +1696,7 @@ def test_optimize_on_js_model_should_ignore_pre_optimized_configurations(
16961696

16971697
assert mock_lmi_js_model.set_deployment_config.call_args_list[0].kwargs == {
16981698
"instance_type": "ml.g5.24xlarge",
1699-
"config_name": "lmi",
1699+
"config_name": mock_lmi_js_model.config_name,
17001700
}
17011701
assert optimized_model.env == {
17021702
"SAGEMAKER_PROGRAM": "inference.py",
@@ -1784,7 +1784,7 @@ def test_optimize_on_js_model_should_ignore_pre_optimized_configurations_no_over
17841784

17851785
assert mock_lmi_js_model.set_deployment_config.call_args_list[0].kwargs == {
17861786
"instance_type": "ml.g5.24xlarge",
1787-
"config_name": "lmi",
1787+
"config_name": mock_lmi_js_model.config_name,
17881788
}
17891789
assert optimized_model.env == {
17901790
"SAGEMAKER_PROGRAM": "inference.py",

0 commit comments

Comments
 (0)