Skip to content

Commit 4707a1c

Browse files
author
Roja Reddy Sareddy
committed
Add Mock setup for mtrl integ tests
1 parent 77fb3af commit 4707a1c

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
270270
assert "pipeline" in execution.arn.lower()
271271
logger.info(f"Started 3P agent base model evaluation: {execution.arn}")
272272

273-
execution.wait()
273+
execution.wait(EVALUATION_TIMEOUT_SECONDS)
274274
assert execution.status.overall_status in ("Succeeded", "Failed", "Stopped")
275275
logger.info(f"Execution completed: {execution.status.overall_status}")
276276

@@ -315,12 +315,15 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
315315
assert execution.arn is not None
316316
logger.info(f"Started CustomAgentLambda object evaluation: {execution.arn}")
317317

318+
execution.wait(EVALUATION_TIMEOUT_SECONDS)
319+
assert execution.status.overall_status == "Succeeded"
320+
318321
def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
319322
"""Test evaluating a fine-tuned model by attaching to an existing training job."""
320323
from sagemaker.train.multi_turn_rl_trainer import MultiTurnRLTrainer
321324

322325
attached_job = MultiTurnRLTrainer.attach(
323-
"openai-reasoning-gpt-oss-20b-mtrl-20260602164546", session=boto3.Session(region_name=_REGION)
326+
"mock-oss-test-mtrl-20260615143910", session=boto3.Session(region_name=_REGION)
324327
)
325328

326329
evaluator = MultiTurnRLEvaluator(
@@ -339,3 +342,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
339342
assert execution is not None
340343
assert execution.arn is not None
341344
logger.info(f"Started attached trainer evaluation: {execution.arn}")
345+
346+
execution.wait(EVALUATION_TIMEOUT_SECONDS)
347+
assert execution.status.overall_status == "Succeeded"

sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ def _get_account_id():
5252
# PROD — Main account (729646638167)
5353
"729646638167": {
5454
"env_name": "PROD",
55-
"existing_job_name": "openai-reasoning-gpt-oss-20b-mtrl-20260602215955",
55+
#"existing_job_name": "mock-oss-test-mtrl-20260611170946",
56+
"existing_job_name": "mock-oss-test-mtrl-20260615143910",
5657
"base_model": "mock-oss-test",
5758
"agent_core_arn": "arn:aws:bedrock-agentcore:us-west-2:729646638167:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
5859
"dataset": "s3://sagemaker-rft-729646638167/prompts/gsm8k_small/prompts.parquet",
@@ -158,10 +159,7 @@ def test_attach_to_existing_job(self, config):
158159
logger.info(f"[{config['env_name']}] Output model package: {job.output_model_package_arn}")
159160

160161
def test_evaluate_finetuned_model(self, attached_trainer, config):
161-
"""Evaluate a fine-tuned model from attached trainer — submit and wait for completion.
162-
163-
Also validates hyperparameter overrides are passed through to the eval job.
164-
"""
162+
"""Evaluate a fine-tuned model from attached trainer — submit and wait for completion."""
165163
evaluator = MultiTurnRLEvaluator(
166164
model=attached_trainer,
167165
dataset=config["dataset"],
@@ -171,10 +169,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
171169
region=_REGION,
172170
)
173171

174-
# Override MTRL-specific hyperparams
175-
evaluator.hyperparameters.sampling_max_tokens = 1024
176-
evaluator.hyperparameters.eval_group_size = 4
177-
178172
execution = evaluator.evaluate()
179173

180174
assert execution is not None

0 commit comments

Comments
 (0)