Skip to content

Commit 4f1985d

Browse files
committed
chore: rename example notebook and add clarifying comments
1 parent b31f02a commit 4f1985d

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,4 @@ sagemaker_train/src/**/container_drivers/sourcecode.json
4242
sagemaker_train/src/**/container_drivers/distributed.json
4343
.kiro
4444
docs/api/generated/
45+
.hypothesis

v3-examples/ml-ops-examples/v3-feature-store-examples/feature-store-lakeformation-cross-account.ipynb renamed to v3-examples/ml-ops-examples/v3-feature-store-examples/v3-feature-store-lake-formation-cross-account.ipynb

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,9 @@
167167
"## 1. Create Feature Group in central account and register it with Lake Formation\n",
168168
"\n",
169169
"We will create a Feature Group with online and offline store. We will use the execution role as a registration role for Lake Formation for simplicity. \n",
170-
"The registration role is the role Lake Formation uses to access your s3 bucket. You also have the option to use a service linked role (SLR). However, an SLR cannot be used with cross-account sharing.\n",
170+
"The registration role is the role Lake Formation uses to access your s3 bucket. You also have the option to use a service linked role (SLR). **However, an SLR cannot be used with cross-account credential vending.**\n",
171+
"\n",
172+
"**Hybrid access mode must also be disabled on Glue Table and Database in order for cross-account credential vending to work**\n",
171173
"\n",
172174
"![lakeformation flow](./imgs/lakeformation-flow.png)"
173175
]
@@ -220,7 +222,8 @@
220222
" enabled=True,\n",
221223
" use_service_linked_role=False,\n",
222224
" registration_role_arn=acc_to_role_arn[central_account],\n",
223-
" disable_hybrid_access_mode=False\n",
225+
" disable_hybrid_access_mode=True,\n",
226+
" acknowledge_risk=True # You acknowledge that IAM based access to the glue table will stop working\n",
224227
")\n",
225228
"\n",
226229
"# create FG in central account and enable LF\n",
@@ -501,6 +504,14 @@
501504
" print('No pending RAM invitations (may already be accepted)')"
502505
]
503506
},
507+
{
508+
"cell_type": "markdown",
509+
"id": "72073ee9",
510+
"metadata": {},
511+
"source": [
512+
"**Hybrid access mode must be disabled on Glue Table and Database in order for cross-account credential vending to work**"
513+
]
514+
},
504515
{
505516
"cell_type": "code",
506517
"execution_count": null,

0 commit comments

Comments
 (0)