Skip to content

Commit 67f3163

Browse files
committed
Fix integ test for test_llm_as_judge_base_model_fix
1 parent a1fa916 commit 67f3163

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

sagemaker-train/tests/integ/train/test_llm_as_judge_base_model_fix.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,23 @@ def test_base_model_evaluation_uses_correct_weights(self):
144144
# Check that we have both base and custom inference steps
145145
step_names = [step.name for step in execution.status.step_details] if execution.status.step_details else []
146146

147-
logger.info(f"Pipeline steps: {step_names}")
147+
logger.info(f"Pipeline steps ({len(step_names)}): {step_names}")
148148

149-
# Verify both inference steps exist
150-
has_base_step = any("BaseInference" in name for name in step_names)
151-
has_custom_step = any("CustomInference" in name for name in step_names)
149+
# If no steps yet, wait a bit for pipeline to initialize
150+
if not step_names:
151+
logger.info("No steps found yet, waiting for pipeline initialization...")
152+
import time
153+
time.sleep(10)
154+
execution.refresh()
155+
step_names = [step.name for step in execution.status.step_details] if execution.status.step_details else []
156+
logger.info(f"Pipeline steps after wait ({len(step_names)}): {step_names}")
152157

153-
assert has_base_step, "Pipeline should have EvaluateBaseInferenceModel step"
154-
assert has_custom_step, "Pipeline should have EvaluateCustomInferenceModel step"
158+
# Verify both inference steps exist (case-insensitive, flexible matching)
159+
has_base_step = any("base" in name.lower() and "inference" in name.lower() for name in step_names)
160+
has_custom_step = any("custom" in name.lower() and "inference" in name.lower() for name in step_names)
161+
162+
assert has_base_step, f"Pipeline should have base inference step. Found steps: {step_names}"
163+
assert has_custom_step, f"Pipeline should have custom inference step. Found steps: {step_names}"
155164

156165
logger.info(f"✓ Pipeline has both base and custom inference steps")
157166
logger.info(f" Base model step: {'Found' if has_base_step else 'Missing'}")
@@ -259,14 +268,23 @@ def test_base_model_false_still_works(self):
259268
execution.refresh()
260269
step_names = [step.name for step in execution.status.step_details] if execution.status.step_details else []
261270

262-
logger.info(f"Pipeline steps: {step_names}")
271+
logger.info(f"Pipeline steps ({len(step_names)}): {step_names}")
272+
273+
# If no steps yet, wait a bit for pipeline to initialize
274+
if not step_names:
275+
logger.info("No steps found yet, waiting for pipeline initialization...")
276+
import time
277+
time.sleep(10)
278+
execution.refresh()
279+
step_names = [step.name for step in execution.status.step_details] if execution.status.step_details else []
280+
logger.info(f"Pipeline steps after wait ({len(step_names)}): {step_names}")
263281

264-
# Should NOT have base inference step
265-
has_base_step = any("BaseInference" in name for name in step_names)
266-
has_custom_step = any("CustomInference" in name for name in step_names)
282+
# Should NOT have base inference step (case-insensitive, flexible matching)
283+
has_base_step = any("base" in name.lower() and "inference" in name.lower() for name in step_names)
284+
has_custom_step = any("custom" in name.lower() and "inference" in name.lower() for name in step_names)
267285

268-
assert not has_base_step, "Pipeline should NOT have EvaluateBaseInferenceModel step when evaluate_base_model=False"
269-
assert has_custom_step, "Pipeline should have EvaluateCustomInferenceModel step"
286+
assert not has_base_step, f"Pipeline should NOT have base inference step when evaluate_base_model=False. Found steps: {step_names}"
287+
assert has_custom_step, f"Pipeline should have custom inference step. Found steps: {step_names}"
270288

271289
logger.info(f"✓ Pipeline structure correct for evaluate_base_model=False")
272290
logger.info(f" Base model step: {'Found (ERROR!)' if has_base_step else 'Not present (correct)'}")

0 commit comments

Comments
 (0)