Added additional checking of duplicate iceberg properties and testing

Author: alexyoung13

sagemaker-mlops/src/sagemaker/mlops/feature_store/feature_group_manager.py

@@ -61,7 +61,7 @@ def validate_property_keys(self):
         # Check for no duplicate keys
         if len(set(self.properties.keys())) != len(self.properties.keys()):
             raise ValueError(
-                f"Invalide duplicate properties. Please only have 1 of each property."
+                f"Invalid duplicate properties. Please only have 1 of each property."
             )
         return self
 
@@ -819,6 +819,12 @@ def _update_iceberg_properties(
                 f"Approved properties are: {_APPROVED_ICEBERG_PROPERTIES}"
             )
 
+         # Check for no duplicate keys
+        if len(set(iceberg_properties.properties.keys())) != len(iceberg_properties.properties.keys()):
+            raise ValueError(
+                f"Invalid duplicate properties. Please only have 1 of each property."
+            )
+
         result = self._get_iceberg_properties(session=session, region=region)
         database_name = result["database_name"]
         table_name = result["table_name"]

sagemaker-mlops/tests/unit/sagemaker/mlops/feature_store/test_iceberg_properties.py

@@ -56,6 +56,24 @@ def test_error_message_contains_invalid_key_names(self):
         with pytest.raises(ValueError, match="fake.property"):
             IcebergProperties(properties={"fake.property": "value"})
 
+    def test_duplicate_keys_raises_error(self):
+        """Test that duplicate property keys raise ValueError."""
+        config = IcebergProperties(properties={"write.target-file-size-bytes": "536870912"})
+        mock_props = MagicMock()
+        mock_props.keys.return_value = [
+            "write.target-file-size-bytes",
+            "write.target-file-size-bytes",
+        ]
+        object.__setattr__(config, "properties", mock_props)
+        with pytest.raises(ValueError, match="Invalid duplicate properties"):
+            config.validate_property_keys()
+
+    def test_no_duplicate_keys_passes(self):
+        """Test that unique approved keys pass duplicate validation."""
+        config = IcebergProperties(properties={"write.target-file-size-bytes": "536870912"})
+        result = config.validate_property_keys()
+        assert result is config
+
 
 class TestGetIcebergProperties:
     """Tests for get_iceberg_properties method."""
@@ -278,6 +296,20 @@ def test_raises_runtime_error_on_update_table_client_error(self):
         with pytest.raises(RuntimeError, match="Failed to update Iceberg properties"):
             self.fg._update_iceberg_properties(iceberg_properties=props)
 
+    def test_raises_error_on_duplicate_keys(self):
+        """Test ValueError when iceberg_properties has duplicate keys."""
+        props = IcebergProperties(properties={"write.target-file-size-bytes": "536870912"})
+        mock_props = MagicMock()
+        mock_props.keys.return_value = [
+            "write.target-file-size-bytes",
+            "write.target-file-size-bytes",
+        ]
+        mock_props.__bool__ = lambda self: True
+        object.__setattr__(props, "properties", mock_props)
+
+        with pytest.raises(ValueError, match="Invalid duplicate properties"):
+            self.fg._update_iceberg_properties(iceberg_properties=props)
+
 
 class TestCreateWithIcebergProperties:
     """Tests for create() method with iceberg_properties parameter."""