Skip to content

Commit 7514ddb

Browse files
author
Syed Jafri
committed
fix image retriever tests
1 parent ab4e389 commit 7514ddb

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

sagemaker-core/src/sagemaker/core/image_retriever/image_retriever.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252

5353

5454
class ImageRetriever:
55+
_config = SageMakerConfig()
56+
5557
@staticmethod
5658
def retrieve_hugging_face_uri(
5759
region: str,
@@ -110,7 +112,7 @@ def retrieve_hugging_face_uri(
110112
args = dict(locals())
111113
for name, val in args.items():
112114
if name in CONFIGURABLE_ATTRIBUTES and not val:
113-
default_value = SageMakerConfig.resolve_value_from_config(
115+
default_value = ImageRetriever._config.resolve_value_from_config(
114116
config_path=_simple_path(
115117
SAGEMAKER, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
116118
)
@@ -499,7 +501,7 @@ def retrieve(
499501
args = dict(locals())
500502
for name, val in args.items():
501503
if name in CONFIGURABLE_ATTRIBUTES and not val:
502-
default_value = SageMakerConfig.resolve_value_from_config(
504+
default_value = ImageRetriever._config.resolve_value_from_config(
503505
config_path=_simple_path(
504506
SAGEMAKER, MODULES, IMAGE_RETRIEVER, to_camel_case(name)
505507
)

sagemaker-core/tests/integ/image_retriever/test_image_retriever.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from sagemaker.core.config.config_manager import SageMakerConfig
1313

1414

15-
@pytest.mark.skip("Disabling this for now, Need to be fixed")
1615
@pytest.mark.integ
1716
def test_retrieve_image_uri():
1817
image_uri = ImageRetriever.retrieve("clarify", "us-west-2")
@@ -56,7 +55,6 @@ def test_retrieve_image_uri():
5655
)
5756

5857

59-
@pytest.mark.skip("Disabling this for now, Need to be fixed")
6058
@pytest.mark.integ
6159
def test_retrieve_pytorch_uri():
6260
image_uri = ImageRetriever.retrieve_pytorch_uri(
@@ -72,7 +70,6 @@ def test_retrieve_pytorch_uri():
7270
)
7371

7472

75-
@pytest.mark.skip("Disabling this for now, Need to be fixed")
7673
@pytest.mark.integ
7774
def test_retrieve_hugging_face_uri():
7875
image_uri = ImageRetriever.retrieve_hugging_face_uri(
@@ -88,18 +85,16 @@ def test_retrieve_hugging_face_uri():
8885
":2.0.0-transformers4.28.1-gpu-py310-cu118-ubuntu20.04"
8986

9087

91-
@pytest.mark.skip("Disabling this for now, Need to be fixed")
9288
@pytest.mark.integ
9389
def test_retrieve_base_python_image_uri():
94-
image_uri = ImageRetriever.retrieve_base_python_image_uri()
90+
image_uri = ImageRetriever.retrieve_base_python_image_uri(region="us-west-2")
9591
assert image_uri == "236514542706.dkr.ecr.us-west-2.amazonaws.com/sagemaker-base-python-310:1.0"
9692

9793

98-
@pytest.mark.skip("Disabling this for now, Need to be fixed")
9994
@pytest.mark.integ
10095
@patch.object(SageMakerConfig, "resolve_value_from_config")
10196
def test_retrieve_image_uri_intelligent_default(mock_load_config):
102-
def custom_return(config_path):
97+
def custom_return(config_path=None, **kwargs):
10398
if config_path == _simple_path(
10499
SAGEMAKER, PYTHON_SDK, MODULES, IMAGE_RETRIEVER, "ImageScope"
105100
):

0 commit comments

Comments
 (0)