Skip to content

Commit 8158657

Browse files
committed
Removed excess fields from glue call in _get_iceberg_properties()
1 parent c2426fe commit 8158657

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

sagemaker-mlops/src/sagemaker/mlops/feature_store/feature_group_manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ def _get_iceberg_properties(
151151
"CatalogId",
152152
"VersionId",
153153
"FederatedTable",
154+
"IsMultiDialectView",
155+
"IsMaterializedView",
154156
]
155157
for field in fields_to_remove:
156158
table_input.pop(field, None)

sagemaker-mlops/tests/unit/sagemaker/mlops/feature_store/test_iceberg_properties.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ def test_successful_get_table_and_field_stripping(self, mock_session_class):
143143
"CatalogId": "123456789012",
144144
"VersionId": "1",
145145
"FederatedTable": {},
146+
"IsMultiDialectView": False,
147+
"IsMaterializedView": False,
146148
}
147149
}
148150

@@ -153,7 +155,8 @@ def test_successful_get_table_and_field_stripping(self, mock_session_class):
153155
assert result["glue_client"] == mock_glue_client
154156
# Verify stripped fields are not in table_input
155157
for field in ["DatabaseName", "CreateTime", "UpdateTime", "CreatedBy",
156-
"IsRegisteredWithLakeFormation", "CatalogId", "VersionId", "FederatedTable"]:
158+
"IsRegisteredWithLakeFormation", "CatalogId", "VersionId", "FederatedTable",
159+
"IsMultiDialectView", "IsMaterializedView"]:
157160
assert field not in result["table_input"]
158161
# Verify kept fields remain
159162
assert result["table_input"]["Name"] == "test_table"

0 commit comments

Comments
 (0)