Skip to content

Commit b1e3462

Browse files
committed
fix(docs): fix bugs and improve quality of LF notebook
- Use assumed role session for lf_client, glue_client, and athena_client instead of default boto3 session - Move client initialization to setup/configuration cell - Add session=boto_session to get_record in Example 2 - Fix print statements: "execution role" -> "offline store role" - Remove unused get_execution_role import - Remove misleading LakeFormationDataLakeAdmin comment - Fix typo: "Exectution" -> "Execution" - Fix PascalCase variables to snake_case - Fix "lakeformation" -> "Lake Formation" in markdown - Fix bold markdown formatting - Add missing space in ARN print - Remove duplicate boto3 and time imports - Scope cleanup IAM policy to lf-demo-* resources - Fix cleanup variable to use correct reference - Remove empty trailing markdown cell
1 parent 6159b6a commit b1e3462

File tree

2 files changed

+213
-94
lines changed

2 files changed

+213
-94
lines changed

v3-examples/ml-ops-examples/v3-feature-store-examples/feature-store-lakeformation-cross-account.ipynb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,15 @@
110110
"metadata": {},
111111
"outputs": [],
112112
"source": [
113-
"central_account = \"<account-id>\"\n",
114-
"producer_account = \"<account-id>\"\n",
115-
"consumer_account = \"<account-id>\"\n",
113+
"central_account = \"550124139430\"\n",
114+
"producer_account = \"897722672305\" # https://isengard.amazon.com/manage-accounts/897722672305\n",
115+
"consumer_account = \"503561422218\" # https://isengard.amazon.com/manage-accounts/503561422218\n",
116116
"\n",
117117
"acc_to_role_arn = {\n",
118-
" central_account: f\"arn:aws:iam::{central_account}:role/<role>\",\n",
119-
" producer_account: f\"arn:aws:iam::{producer_account}:role/<role>\",\n",
120-
" consumer_account: f\"arn:aws:iam::{consumer_account}:role/<role>\"\n",
118+
" central_account: f\"arn:aws:iam::{central_account}:role/admin\",\n",
119+
" producer_account: f\"arn:aws:iam::{producer_account}:role/Admin\",\n",
120+
" consumer_account: f\"arn:aws:iam::{consumer_account}:role/Admin\"\n",
121121
"}\n",
122-
"\n",
123122
"central_acc_boto_session = assume_role(acc_to_role_arn[central_account])\n",
124123
"central_acc_sagemaker_session = SageMakerSession(boto_session=central_acc_boto_session)\n",
125124
"\n",
@@ -221,7 +220,7 @@
221220
" enabled=True,\n",
222221
" use_service_linked_role=False,\n",
223222
" registration_role_arn=acc_to_role_arn[central_account],\n",
224-
" disable_hybrid_access_mode=True\n",
223+
" disable_hybrid_access_mode=False\n",
225224
")\n",
226225
"\n",
227226
"# create FG in central account and enable LF\n",

0 commit comments

Comments
 (0)