Skip to content

Commit becb139

Browse files
committed
fix(docs): fix bugs and improve quality of LF notebook
- Use assumed role session for lf_client, glue_client, and athena_client instead of default boto3 session - Move client initialization to setup/configuration cell - Add session=boto_session to get_record in Example 2 - Fix print statements: "execution role" -> "offline store role" - Remove unused get_execution_role import - Remove misleading LakeFormationDataLakeAdmin comment - Fix typo: "Exectution" -> "Execution" - Fix PascalCase variables to snake_case - Fix "lakeformation" -> "Lake Formation" in markdown - Fix bold markdown formatting - Add missing space in ARN print - Remove duplicate boto3 and time imports - Scope cleanup IAM policy to lf-demo-* resources - Fix cleanup variable to use correct reference - Remove empty trailing markdown cell
1 parent 6159b6a commit becb139

2 files changed

Lines changed: 207 additions & 88 deletions

File tree

v3-examples/ml-ops-examples/v3-feature-store-examples/feature-store-lakeformation-cross-account.ipynb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@
119119
" producer_account: f\"arn:aws:iam::{producer_account}:role/<role>\",\n",
120120
" consumer_account: f\"arn:aws:iam::{consumer_account}:role/<role>\"\n",
121121
"}\n",
122-
"\n",
123122
"central_acc_boto_session = assume_role(acc_to_role_arn[central_account])\n",
124123
"central_acc_sagemaker_session = SageMakerSession(boto_session=central_acc_boto_session)\n",
125124
"\n",
@@ -221,7 +220,7 @@
221220
" enabled=True,\n",
222221
" use_service_linked_role=False,\n",
223222
" registration_role_arn=acc_to_role_arn[central_account],\n",
224-
" disable_hybrid_access_mode=True\n",
223+
" disable_hybrid_access_mode=False\n",
225224
")\n",
226225
"\n",
227226
"# create FG in central account and enable LF\n",

0 commit comments

Comments
 (0)