Skip to content

Commit de81247

Browse files
committed
Add -mindepth
1 parent 4e5fda9 commit de81247

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

sagemaker-core/src/sagemaker/core/modules/local_core/local_container.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def _rmtree(path, image=None, is_studio=False):
7575
cmd = ["docker", "run", "--rm"]
7676
if is_studio:
7777
cmd += ["--network", "sagemaker"]
78-
cmd += ["-v", f"{path}:/delete", image, "rm", "-rf", "/delete"]
78+
cmd += ["-v", f"{path}:/delete", image, "sh", "-c", "find /delete -mindepth 1 -delete"]
7979
subprocess.run(cmd, check=True, capture_output=True)
8080
# The mount point directory itself may remain — clean it up
8181
if os.path.exists(path):

sagemaker-train/src/sagemaker/train/local/local_container.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def _rmtree(path, image=None, is_studio=False):
8383
cmd = ["docker", "run", "--rm"]
8484
if is_studio:
8585
cmd += ["--network", "sagemaker"]
86-
cmd += ["-v", f"{path}:/delete", image, "rm", "-rf", "/delete"]
86+
cmd += ["-v", f"{path}:/delete", image, "sh", "-c", "find /delete -mindepth 1 -delete"]
8787
subprocess.run(cmd, check=True, capture_output=True)
8888
# The mount point directory itself may remain — clean it up
8989
if os.path.exists(path):

sagemaker-train/tests/unit/train/local/test_local_container.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ def test_rmtree_permission_error_docker_fallback(self, mock_exists, mock_run, mo
3737
_rmtree("/tmp/test", IMAGE)
3838

3939
mock_run.assert_called_once_with(
40-
["docker", "run", "--rm", "-v", "/tmp/test:/delete", IMAGE, "rm", "-rf", "/delete"],
40+
[
41+
"docker", "run", "--rm",
42+
"-v", "/tmp/test:/delete", IMAGE,
43+
"sh", "-c", "find /delete -mindepth 1 -delete",
44+
],
4145
check=True,
4246
capture_output=True,
4347
)
@@ -55,7 +59,8 @@ def test_rmtree_studio_adds_network(self, mock_exists, mock_run, mock_rmtree):
5559
[
5660
"docker", "run", "--rm",
5761
"--network", "sagemaker",
58-
"-v", "/tmp/test:/delete", IMAGE, "rm", "-rf", "/delete",
62+
"-v", "/tmp/test:/delete", IMAGE,
63+
"sh", "-c", "find /delete -mindepth 1 -delete",
5964
],
6065
check=True,
6166
capture_output=True,

0 commit comments

Comments
 (0)