Skip to content

Commit e69f8db

Browse files
author
Harsh Thakkar
committed
fix: correct test mocks to use 'default' key matching real _extract_eval_override_options return format
1 parent e35bb2f commit e69f8db

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

sagemaker-train/tests/unit/train/evaluate/test_custom_scorer_evaluator.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ def test_custom_scorer_evaluator_get_custom_scorer_template_additions_with_aggre
446446

447447
# Mock recipe utils
448448
mock_get_params.return_value = {'temperature': 0.5}
449-
mock_extract_options.return_value = {'temperature': {'value': 0.5}}
449+
mock_extract_options.return_value = {'temperature': {'default': 0.5}}
450450

451451
evaluator = CustomScorerEvaluator(
452452
evaluator=DEFAULT_EVALUATOR_ARN,
@@ -610,7 +610,7 @@ def test_custom_scorer_evaluator_evaluate_method(
610610

611611
# Mock recipe utils
612612
mock_get_params.return_value = {'temperature': 0.7}
613-
mock_extract_options.return_value = {'temperature': {'value': 0.7}}
613+
mock_extract_options.return_value = {'temperature': {'default': 0.7}}
614614

615615
# Mock Pipeline and execution
616616
mock_pipeline_instance = Mock()
@@ -673,7 +673,7 @@ def test_custom_scorer_evaluator_evaluate_with_model_package(
673673

674674
# Mock recipe utils
675675
mock_get_params.return_value = {'temperature': 0.7}
676-
mock_extract_options.return_value = {'temperature': {'value': 0.7}}
676+
mock_extract_options.return_value = {'temperature': {'default': 0.7}}
677677

678678
# Mock Pipeline and execution
679679
mock_pipeline_instance = Mock()
@@ -839,8 +839,8 @@ def test_custom_scorer_evaluator_hyperparameters_property(mock_artifact, mock_re
839839
# Mock recipe utils
840840
mock_get_params.return_value = {'temperature': 0.7, 'max_new_tokens': 2048}
841841
mock_extract_options.return_value = {
842-
'temperature': {'value': 0.7, 'type': 'float', 'min': 0.0, 'max': 1.0},
843-
'max_new_tokens': {'value': 2048, 'type': 'int', 'min': 1, 'max': 8192}
842+
'temperature': {'default': 0.7, 'type': 'float', 'min': 0.0, 'max': 1.0},
843+
'max_new_tokens': {'default': 2048, 'type': 'int', 'min': 1, 'max': 8192}
844844
}
845845

846846
evaluator = CustomScorerEvaluator(
@@ -933,7 +933,7 @@ def test_custom_scorer_evaluator_get_custom_scorer_template_additions_builtin(
933933

934934
# Mock recipe utils
935935
mock_get_params.return_value = {'temperature': 0.7}
936-
mock_extract_options.return_value = {'temperature': {'value': 0.7}}
936+
mock_extract_options.return_value = {'temperature': {'default': 0.7}}
937937

938938
evaluator = CustomScorerEvaluator(
939939
evaluator=_BuiltInMetric.PRIME_MATH,
@@ -988,8 +988,8 @@ def test_custom_scorer_evaluator_get_custom_scorer_template_additions_custom_arn
988988
# Mock recipe utils
989989
mock_get_params.return_value = {'temperature': 0.5, 'aggregation': 'median'}
990990
mock_extract_options.return_value = {
991-
'temperature': {'value': 0.5},
992-
'aggregation': {'value': 'median'}
991+
'temperature': {'default': 0.5},
992+
'aggregation': {'default': 'median'}
993993
}
994994

995995
evaluator = CustomScorerEvaluator(
@@ -1048,7 +1048,7 @@ def test_custom_scorer_evaluator_lambda_type_for_nova_models(
10481048

10491049
# Mock recipe utils
10501050
mock_get_params.return_value = {'temperature': 0.7}
1051-
mock_extract_options.return_value = {'temperature': {'value': 0.7}}
1051+
mock_extract_options.return_value = {'temperature': {'default': 0.7}}
10521052

10531053
# Mock is_nova_model to return True
10541054
mock_is_nova.return_value = True
@@ -1105,7 +1105,7 @@ def test_custom_scorer_evaluator_no_lambda_type_for_non_nova_models(
11051105

11061106
# Mock recipe utils
11071107
mock_get_params.return_value = {'temperature': 0.7}
1108-
mock_extract_options.return_value = {'temperature': {'value': 0.7}}
1108+
mock_extract_options.return_value = {'temperature': {'default': 0.7}}
11091109

11101110
# Mock is_nova_model to return False
11111111
mock_is_nova.return_value = False

0 commit comments

Comments
 (0)