fix: aws_batch integ test resources are now uniquely named by test run.#5666
Merged
mollyheamazon merged 1 commit intoaws:masterfrom Mar 25, 2026
Merged
Conversation
davlind-amzn
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
davlind-amzn
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
davlind-amzn
force-pushed
the
davlind_qm_test_fix
branch
from
c475138 to
750a626
Compare
davlind-amzn
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
davlind-amzn
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
approved these changes
Mar 25, 2026
| yield resource_manager | ||
| except Exception as e: | ||
| print(f"Exception thrown while creating or yielding AWS Batch resources: {str(e)}") | ||
|
|
Contributor
There was a problem hiding this comment.
should raise exception here
add raise
Collaborator
Author
There was a problem hiding this comment.
I intentionally didn't raise here because I want cleanup to still attempt if we catch an exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: aws_batch integ test resources are now uniquely named by test run. This is required to prevent overlapping test runtimes (e.g. when multiple pysdk PRs are open) clobbering each other's AWS Batch test resources. Resource creation is also now simplified by eliminating the option to reuse resources between independent test executions (wasn't used prior).
Other changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.