fix: add role parameter to BaseEvaluator#5671
Merged
mollyheamazon merged 1 commit intoaws:masterfrom Mar 25, 2026
Merged
Conversation
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mattliu-mygit
approved these changes
Mar 24, 2026
aviruthen
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Ticket: https://tiny.amazon.com/9v6vezon/tcorpamazP403over
Description of changes:
BaseEvaluator(and all subclasses —LLMAsJudgeEvaluator, BenchMarkEvaluator, CustomScorerEvaluator) had no way to accept an explicit IAM execution role. The role was always derived fromsagemaker_session.get_caller_identity_arn(), which returns the caller's identity rather than a SageMaker-assumable service role. This caused pipeline execution failures when running outside SageMaker-managed environments (local notebooks, CI/CD, Kiro IDE).Every other job-submitting class in the SDK (
ModelTrainer, SFTTrainer, RLVRTrainer) acceptsrole=—BaseEvaluatorwas the outlier.Changes:
role: Optional[str] = NonetoBaseEvaluator_get_aws_execution_context()usesself.rolewhen provided, falls back to existing session-derived behaviorBackward compatible —
role=Nonepreserves existing behavior.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.