fix: Pipeline TypeError: can only concatenate list (not "NoneType") to list Using Sou (#5518)#5680
Closed
aviruthen wants to merge 1 commit intoaws:masterfrom
Conversation
…o list Using Sou (aws#5518)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug is a TypeError in
get_code_hash()whenSourceCode.requirementsisNone(the default). In v3.3.1 (the user's version),get_training_code_hash()did[source_dir] + dependencieswheredependencieswasNone, causingTypeError: can only concatenate list (not 'NoneType') to list. The current master code insagemaker-core/src/sagemaker/core/workflow/utilities.pyhas already been partially fixed —get_training_code_hash()now checksif dependencies:before concatenation. However, there is no test coverage forget_code_hash()being called with aTrainingStepwhoseSourceCodehasrequirements=None. Additionally, theget_code_hash()function itself could be more defensive by normalizingNonerequirements before passing them downstream. The fix on master looks correct but test coverage should be added to prevent regression.Related Issue
Fixes #5518
Changes Made
sagemaker-core/src/sagemaker/core/workflow/utilities.pysagemaker-core/tests/unit/workflow/test_utilities.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat