Pin JS model integ test to 4.* version#5777
Merged
Merged
Conversation
zhaoqizqwang
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
model_versionfield toModelBuilderto allow pinning the JumpStart model version. PreviouslyModelBuilderhard-codedmodel_version="*"in its JumpStart resolution path, making it impossible to recover when a JumpStart default points to a broken image (as withmeta-textgeneration-llama-2-7b v5.0.0, whose default container fails to start).Changes
src/sagemaker/serve/builder/model_builder.py: add model_version: Optional[str] = Nonefield + docstring entry.src/sagemaker/serve/builder/jumpstart_builder.py: threadself.model_versioninto_is_jumpstart_model_id()and_create_pre_trained_js_model(), defaulting to "*".tests/unit/sagemaker/serve/builder/test_js_builder.py: 4 unit tests covering default + override at both callsites.tests/integ/sagemaker/serve/test_serve_model_builder_inference_component_happy.py: pin fixture tomodel_version="4.*"to unblock the integ testBackward compatibility
model_versiondefaults toNone→ resolves to "*" at both callsites → identical behavior for all existing callers.Related
Tracking ticket: link (JumpStart team investigating v5.0.0 CannotStartContainerError).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.