Skip to content

Pin JS model integ test to 4.* version#5777

Merged
zhaoqizqwang merged 2 commits into
aws:master-v2from
mollyheamazon:fix/master-v2-integ
Apr 20, 2026
Merged

Pin JS model integ test to 4.* version#5777
zhaoqizqwang merged 2 commits into
aws:master-v2from
mollyheamazon:fix/master-v2-integ

Conversation

@mollyheamazon

@mollyheamazon mollyheamazon commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Add model_version field to ModelBuilder to allow pinning the JumpStart model version. Previously ModelBuilder hard-coded model_version="*" in its JumpStart resolution path, making it impossible to recover when a JumpStart default points to a broken image (as with meta-textgeneration-llama-2-7b v5.0.0, whose default container fails to start).

Changes

  • src/sagemaker/serve/builder/model_builder.py: add model_version: Optional[str] = None field + docstring entry.
  • src/sagemaker/serve/builder/jumpstart_builder.py: thread self.model_version into _is_jumpstart_model_id() and _create_pre_trained_js_model(), defaulting to "*".
  • tests/unit/sagemaker/serve/builder/test_js_builder.py: 4 unit tests covering default + override at both callsites.
  • tests/integ/sagemaker/serve/test_serve_model_builder_inference_component_happy.py: pin fixture to model_version="4.*" to unblock the integ test

Backward compatibility

model_version defaults to None → resolves to "*" at both callsites → identical behavior for all existing callers.

Related

Tracking ticket: link (JumpStart team investigating v5.0.0 CannotStartContainerError).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mollyheamazon mollyheamazon marked this pull request as ready for review April 20, 2026 21:16
@mollyheamazon mollyheamazon requested a review from a team as a code owner April 20, 2026 21:16
@mollyheamazon mollyheamazon requested a review from chad119 April 20, 2026 21:16
@mollyheamazon mollyheamazon changed the title Pin JS model to 4.* version Pin JS model integ test to 4.* version Apr 20, 2026
@zhaoqizqwang zhaoqizqwang merged commit 95bdf1f into aws:master-v2 Apr 20, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants