-
Notifications
You must be signed in to change notification settings - Fork 1.3k
allow SAGEMAKER_HUB_NAME env var override for HUB_NAME constant #5784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| """Tests for SAGEMAKER_HUB_NAME env-var override of the HUB_NAME constant.""" | ||
| from __future__ import absolute_import | ||
|
|
||
| import importlib | ||
| import os | ||
| from unittest.mock import patch | ||
|
|
||
|
|
||
| def _reload_hub_name(): | ||
| """Reload the constants module under the current env and return HUB_NAME.""" | ||
| from sagemaker.train import constants | ||
| importlib.reload(constants) | ||
| return constants.HUB_NAME | ||
|
|
||
|
|
||
| def test_hub_name_defaults_to_public_hub(): | ||
| """When SAGEMAKER_HUB_NAME is unset, HUB_NAME is SageMakerPublicHub.""" | ||
| env = {k: v for k, v in os.environ.items() if k != "SAGEMAKER_HUB_NAME"} | ||
| with patch.dict(os.environ, env, clear=True): | ||
| assert _reload_hub_name() == "SageMakerPublicHub" | ||
|
|
||
|
|
||
| def test_hub_name_overridden_by_env_var(): | ||
| """When SAGEMAKER_HUB_NAME is set, HUB_NAME reflects the override.""" | ||
| with patch.dict(os.environ, {"SAGEMAKER_HUB_NAME": "MyPrivateHub"}): | ||
| assert _reload_hub_name() == "MyPrivateHub" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a function
get_sagemaker_hub_nameinstead of constants so its fetched on runtime ?