feat: Correctly support custom domain in private apis#3750
Merged
rachdry merged 5 commits intoaws:developfrom Apr 10, 2025
Merged
feat: Correctly support custom domain in private apis#3750rachdry merged 5 commits intoaws:developfrom
rachdry merged 5 commits intoaws:developfrom
Conversation
- Add Policy to `AWS::Serverless::Api` - Support Route53 resources correctly - Add a new `AccessAssociation` inside `Domain`, that generates a `AWS::ApiGateway::DomainNameAccessAssociation` resource.
include not only the VpcEndpointId but also the DomainName logical id
rachdry
approved these changes
Apr 10, 2025
mbfreder
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS::Serverless::ApiAccessAssociationinsideDomain, that generates aAWS::ApiGateway::DomainNameAccessAssociationresource.Issue #, if available
Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.