Skip to content

perf: use list join instead of string concatenation in loop #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roger-zhangg merged 4 commits into from
Apr 29, 2026
+3 −3
Merged

perf: use list join instead of string concatenation in loop #3829

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75cbff8
perf: use list join instead of string concatenation in loop
akshatsinha0 Oct 16, 2025
b944a5f
refactor: addressing comment removals
akshatsinha0 Oct 16, 2025
fb91c81
Merge branch 'develop' into perf/optimize-function-names-string-conca…
roger-zhangg Apr 28, 2026
22575a2
style: add missing space after comma (black / ruff format)
roger-zhangg Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions samtranslator/translator/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,15 @@ def _get_function_names(
)
if not resolved_function_name:
continue
self.function_names.setdefault(api_name, "")
self.function_names[api_name] += str(resolved_function_name)
return self.function_names
# OLD APPROACH: String concatenation in loop
# self.function_names.setdefault(api_name, "")
# self.function_names[api_name] += str(resolved_function_name)
# NEW APPROACH: Collect in list
Comment thread
roger-zhangg marked this conversation as resolved.
Outdated
if api_name not in self.function_names:
self.function_names[api_name]=[]
Comment thread
roger-zhangg marked this conversation as resolved.
Outdated
self.function_names[api_name].append(str(resolved_function_name))
#backward compatibility
Comment thread
roger-zhangg marked this conversation as resolved.
Outdated
return {api: "".join(names) for api, names in self.function_names.items()}

def translate( # noqa: PLR0912, PLR0915
self,
Expand All @@ -127,7 +133,9 @@ def translate( # noqa: PLR0912, PLR0915
self.feature_toggle = feature_toggle or FeatureToggle(
FeatureToggleDefaultConfigProvider(), stage=None, account_id=None, region=None
)
self.function_names: Dict[Any, Any] = {}
# OLD: self.function_names: Dict[Any, Any] = {}
# NEW: Use List[str] for efficient accumulation, convert to str when needed
Comment thread
roger-zhangg marked this conversation as resolved.
Outdated
self.function_names: Dict[str, List[str]] = {}
self.redeploy_restapi_parameters = {}
sam_parameter_values = SamParameterValues(parameter_values)
sam_parameter_values.add_default_parameter_values(sam_template)
Expand Down
Loading