Skip to content

improve HttpServletRequest for Springboot4 #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobixlea merged 6 commits into from
Feb 17, 2026
Merged

improve HttpServletRequest for Springboot4 #1590

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26dac66
improve HttpServletRequest for Springboot4
tobixlea Feb 12, 2026
7bdce8e
add null check to generateRequest1
tobixlea Feb 17, 2026
87bda8f
add attribute and null tests to http process test in SB3/4
tobixlea Feb 17, 2026
1a699a1
add further testing for v2 requests
tobixlea Feb 17, 2026
8b2db99
combine v2 request tests into one test
tobixlea Feb 17, 2026
dc667cf
Merge branch 'main' into sjc-spring-boot-update
tobixlea Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions ...ot4/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,33 @@ private static HttpServletRequest generateRequest1(String request, Context lambd
SecurityContextWriter securityWriter, ObjectMapper mapper, ServletContext servletContext) {
AwsProxyRequest v1Request = readValue(request, AwsProxyRequest.class, mapper);

// Use AWS container's servlet request instead of Spring Cloud Function's
AwsProxyHttpServletRequest httpServletRequest = new AwsProxyHttpServletRequest(v1Request, lambdaContext, securityWriter.writeSecurityContext(v1Request, lambdaContext));
httpServletRequest.setServletContext(servletContext);
return httpServletRequest;
ServerlessHttpServletRequest httpRequest = new ServerlessHttpServletRequest(servletContext, v1Request.getHttpMethod(), v1Request.getPath());
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between AwsProxyHttpServletRequest and ServerlessHttpServletRequest? I guess they're both HttpServletRequests but could in theory have different behavior, right? This might be a basic question I'm just not very familiar.


populateQueryStringParametersV1(v1Request, httpRequest);
populateMultiValueQueryStringParametersV1(v1Request, httpRequest);

if (v1Request.getMultiValueHeaders() != null) {
MultiValueMapAdapter headers = new MultiValueMapAdapter(v1Request.getMultiValueHeaders());
httpRequest.setHeaders(headers);
}
populateContentAndContentType(
v1Request.getBody(),
v1Request.getMultiValueHeaders().getFirst(HttpHeaders.CONTENT_TYPE),
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could getMultiValueHeaders be null? There's a check for it above and this code runs regardless.

v1Request.isBase64Encoded(),
httpRequest
);
if (v1Request.getRequestContext() != null) {
httpRequest.setAttribute(RequestReader.API_GATEWAY_CONTEXT_PROPERTY, v1Request.getRequestContext());
httpRequest.setAttribute(RequestReader.ALB_CONTEXT_PROPERTY, v1Request.getRequestContext().getElb());
}
httpRequest.setAttribute(RequestReader.API_GATEWAY_STAGE_VARS_PROPERTY, v1Request.getStageVariables());
httpRequest.setAttribute(RequestReader.API_GATEWAY_EVENT_PROPERTY, v1Request);
httpRequest.setAttribute(RequestReader.LAMBDA_CONTEXT_PROPERTY, lambdaContext);
httpRequest.setAttribute(RequestReader.JAX_SECURITY_CONTEXT_PROPERTY,
securityWriter.writeSecurityContext(v1Request, lambdaContext));
return httpRequest;
}




Expand Down
Loading