updated Scenario

Author: scmacdon

javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorActions.java

@@ -437,9 +437,10 @@ public CompletableFuture<String> createLowSeverityFilterAsync(
     /**
      * Lists all AWS Inspector findings of LOW severity asynchronously.
      *
-     * @return CompletableFuture containing either "No findings found." or the ARNs of all LOW findings.
+     * @return CompletableFuture containing a List of finding ARNs.
+     * Returns an empty list if no LOW severity findings are found.
      */
-    public CompletableFuture<String> listLowSeverityFindingsAsync() {
+    public CompletableFuture<ArrayList<String>> listLowSeverityFindingsAsync() {
         logger.info("Starting async LOW severity findings paginator…");
 
         // Build a filter criteria for LOW severity.
@@ -471,13 +472,7 @@ public CompletableFuture<String> listLowSeverityFindingsAsync() {
                     }
                 })
                 .thenRun(() -> logger.info("Successfully listed all LOW severity findings."))
-                .thenApply(v -> {
-                    if (allArns.isEmpty()) {
-                        return "No LOW severity findings found.";
-                    } else {
-                        return String.join("\n", allArns);
-                    }
-                })
+                .thenApply(v -> new ArrayList<>(allArns)) // Return list instead of a formatted string
                 .exceptionally(ex -> {
                     Throwable cause = ex.getCause() != null ? ex.getCause() : ex;
                     if (cause instanceof ValidationException ve) {
@@ -489,6 +484,7 @@ public CompletableFuture<String> listLowSeverityFindingsAsync() {
                     throw new RuntimeException("Failed to list LOW severity findings", ex);
                 });
     }
+
     // snippet-end:[inspector.java2.list_findings.main]
 
     // snippet-start:[inspector.java2.list_coverage.main]

javav2/example_code/inspector/src/main/java/com/java/inspector/InspectorScenario.java

@@ -5,6 +5,8 @@
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+
+import java.util.List;
 import java.util.Scanner;
 
 // snippet-start:[inspector.java2_scenario.main]
@@ -95,19 +97,20 @@ public static void runScenario(InspectorActions actions) {
 
             // Step 3
             logger.info(DASHES);
-            logger.info("Step 3: Listing findings...");
-            String allFindings = actions.listLowSeverityFindingsAsync().join();
+            logger.info("Step 3: Listing LOW severity findings...");
 
-            if (!allFindings.equals("No findings found.")) {
-                String[] arns = allFindings.split("\\r?\\n");
-                String lastArn = arns[arns.length - 1];
+            // Call the service method
+            List<String> allFindings = actions.listLowSeverityFindingsAsync().join();
 
+            if (!allFindings.isEmpty()) {
+                // Only proceed if there are findings
+                String lastArn = allFindings.get(allFindings.size() - 1);
                 logger.info("Look up details on: {}", lastArn);
                 waitForInputToContinue();
                 String details = actions.getFindingDetailsAsync(lastArn).join();
                 logger.info(details);
             } else {
-                logger.info("No findings found.");
+                logger.info("No LOW severity findings found.");
             }
 
             waitForInputToContinue();

javav2/example_code/inspector/src/test/java/InspectorTests.java

@@ -21,6 +21,7 @@
 import java.io.InputStream;
 import java.io.PrintStream;
 import java.util.Collections;
+import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.*;
 
@@ -72,19 +73,23 @@ public void testInspectorActionsIntegration() {
 
             inspectorActions.enableInspectorAsync(null).join();
 
-            String allFindings = inspectorActions.listLowSeverityFindingsAsync().join();
-            // Check if any findings were returned
-            if (allFindings == null || allFindings.startsWith("No LOW severity findings")) {
-                logger.info("No LOW severity findings available. Skipping details lookup.");
+            List<String> allFindings = inspectorActions.listLowSeverityFindingsAsync().join();
+
+            if (allFindings.isEmpty()) {
+                logger.info("No LOW severity findings found.");
             } else {
-                String[] arns = allFindings.split("\\r?\\n");
-                String lastArn = arns[arns.length - 1];
+                logger.info("Found {} LOW severity findings.", allFindings.size());
 
-                // Fetch details safely
-                String details = inspectorActions.getFindingDetailsAsync(lastArn).join();
-                logger.info("Details for last LOW severity finding:\n{}", details);
-            }
+                // Optionally, iterate over all findings to test getFindingDetailsAsync
+                for (String arn : allFindings) {
+                    logger.info("Fetching details for finding ARN: {}", arn);
+                    String details = inspectorActions.getFindingDetailsAsync(arn).join();
 
+                    // Check details are not empty/null
+                    assertNotNull(details, "Finding details should not be null");
+                    assertFalse(details.isEmpty(), "Finding details should not be empty");
+                }
+            }
 
             maxResults = 5;
             inspectorActions.listCoverageAsync(maxResults).join();