Skip to content

Swift: code examples for Meta Llama to use Converse and ConverseStream, Amazon Bedrock#7434

Merged
scmacdon merged 5 commits into
awsdocs:mainfrom
monadierickx:llama-converse
Jun 6, 2025
Merged

Swift: code examples for Meta Llama to use Converse and ConverseStream, Amazon Bedrock#7434
scmacdon merged 5 commits into
awsdocs:mainfrom
monadierickx:llama-converse

Conversation

@monadierickx

Copy link
Copy Markdown
Contributor

This pull request contains code examples for Meta Llama similar to the examples for Amazon Nova.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions Bot added the Swift This issue relates to the AWS SDK for Swift label May 6, 2025

@sebsto sebsto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor change requests

Comment thread .doc_gen/metadata/bedrock-runtime_metadata.yaml Outdated
Comment thread swift/example_code/bedrock-runtime/README.md
@monadierickx monadierickx marked this pull request as ready for review May 6, 2025 11:12
@DennisTraub DennisTraub self-requested a review May 20, 2025 07:04

@DennisTraub DennisTraub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brmur brmur added Feature Scenario A simple code example to show how certain tasks can be accomplished using several services and SDKs. On Call Review complete On call review complete and removed On Call Review complete On call review complete labels May 28, 2025

@shepazon shepazon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto

sebsto commented Jun 5, 2025

Copy link
Copy Markdown

@DennisTraub @shepazon How can we get this merged ?

@shepazon shepazon added the On Call Review needed This work needs an on-call review label Jun 5, 2025
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jun 6, 2025
@scmacdon

scmacdon commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

There seems to be a conflict here that needs to be fixed

@scmacdon scmacdon merged commit 85042e5 into awsdocs:main Jun 6, 2025
17 checks passed
monadierickx added a commit to monadierickx/aws-doc-sdk-examples that referenced this pull request Jun 16, 2025
monadierickx added a commit to monadierickx/aws-doc-sdk-examples that referenced this pull request Jun 16, 2025
DennisTraub pushed a commit that referenced this pull request Jul 17, 2025
DennisTraub pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Scenario A simple code example to show how certain tasks can be accomplished using several services and SDKs. On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants