Java: Add basic SaaS code samples for CloudFront#7501
Java: Add basic SaaS code samples for CloudFront#7501Dogiogi25 wants to merge 3 commits intoawsdocs:mainfrom
Conversation
2da9136 to
ef2b492
Compare
|
I am reviewing this code |
|
Regarding the main(), I was following our existing patterns here + writing them as utility-focused classes so I thought it wouldn't be necessary: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/java_cloudfront_code_examples.html I can add if absolutely necessary, but I don't think it's necessary for this style of code snippet + scenario |
3c4b0e2 to
8d22239
Compare
|
And thanks, a new version of the commit has been pushed with the updated import list |
tkhill-AWS
left a comment
There was a problem hiding this comment.
Integration test is needed.
2fe5ccf to
7f06ce4
Compare
7f06ce4 to
111becc
Compare
Thanks, added in current commit, lmk if printouts or results are necessary to be shared somewhere |
scmacdon
left a comment
There was a problem hiding this comment.
Cloud Desktop build and code looks good, I approve this.
|
@scmacdon WRITEME is failing with known error. Can you please address? |
scmacdon
left a comment
There was a problem hiding this comment.
This PE builds the CD and code is fine.
This pull request adds code samples for new SaaS APIs in CloudFront for Javav2 SDK
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.