Java v2: Update S3 examples of uploading from a stream of unknown size to remove use of BlockingInputStreamAsyncRequestBody#7513
Merged
Conversation
github-actions
Bot
added
the
Java-v2
scmacdon
added
the
Single action example
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
Show me a Cloud Desktop |
Collaborator
Author
|
The link to the CDD is in the main description. |
scmacdon
approved these changes
Jul 7, 2025
rlhagerm
added
On Call Review complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates two S3 code examples that show the use of
BlockingInputStreamAsyncRequestBodywhen uploading content from a stream of unknown size. It turns out that this approach is 'dangerous' according to the Java SDK team and an update was recommended.This PR also adds an one more example that uses same upload approach using the standard S3 async client with multipart enabled that users can alternatively use to upload.
There are now 3 examples using different clients.
CDD build is here.
Addresses this ticket.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.