Rust: Add Comprehend Getting Started scenario using Code Loom#7553
Closed
beqqrry-aws wants to merge 1 commit intoawsdocs:mainfrom
Closed
Rust: Add Comprehend Getting Started scenario using Code Loom#7553beqqrry-aws wants to merge 1 commit intoawsdocs:mainfrom
beqqrry-aws wants to merge 1 commit intoawsdocs:mainfrom
Conversation
github-actions
Bot
added
the
Rust
|
|
||
| #[derive(Debug, Parser)] | ||
| struct Opt { | ||
| /// The text to analyze for entities. |
Contributor
There was a problem hiding this comment.
Meh - these comments sorta suck
| .send() | ||
| .await?; | ||
|
|
||
| println!("Detected entities:"); |
| assert!(result.is_ok(), "Comprehend scenario should complete successfully: {:?}", result); | ||
| } | ||
|
|
||
| #[tokio::test] |
Contributor
There was a problem hiding this comment.
These are full integration tests, I'm not sure if I support this. Since they require network access.
Contributor
Author
There was a problem hiding this comment.
We have settled on having full integration tests for our examples as a cross-language standard, so this existing does fit the requirements.
| } | ||
|
|
||
| let primary_language = &languages[0]; | ||
| let language_code = primary_language.language_code().unwrap_or("en"); |
Contributor
There was a problem hiding this comment.
I don't think this is a correct unwrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.