Skip to content

feat: add aws-amplify plugin#18

Merged
hfurkanbozkurt merged 1 commit into
awslabs:mainfrom
must1d:aws-amplify
Mar 16, 2026
Merged

feat: add aws-amplify plugin#18
hfurkanbozkurt merged 1 commit into
awslabs:mainfrom
must1d:aws-amplify

Conversation

@must1d

@must1d must1d commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Related

N/A

Changes

Add the aws-amplify plugin for building full-stack apps with AWS Amplify Gen 2.

  • Marketplace: Register aws-amplify plugin in .claude-plugin/marketplace.json
  • Plugin manifest: plugins/aws-amplify/.claude-plugin/plugin.json with metadata (author, license, keywords)
  • MCP server: .mcp.json configuring aws-mcp (via mcp-proxy-for-aws) for SOP retrieval
  • Slash command: commands/build.md/aws-amplify:build for explicit invocation
  • Auto-triggered skill: skills/amplify-workflow/SKILL.md — orchestrates a phased workflow (Backend → Sandbox →
    Frontend → Testing → Production) driven by official AWS SOPs
  • README: Documentation covering installation, usage, prerequisites, and plugin structure

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

hfurkanbozkurt
hfurkanbozkurt previously approved these changes Feb 10, 2026
@must1d must1d changed the title add aws-amplify plugin feat: add aws-amplify plugin Feb 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new aws-amplify plugin to the repository’s plugin marketplace, intended to guide developers through AWS Amplify Gen 2 full-stack workflows using SOP-driven phases and an MCP-backed SOP retrieval server.

Changes:

  • Registers the aws-amplify plugin in the central marketplace registry.
  • Adds plugin assets: manifest, MCP server config, slash command, and an auto-invoked “amplify-workflow” skill.
  • Adds plugin-level documentation describing installation and usage.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
plugins/aws-amplify/skills/amplify-workflow/SKILL.md Adds the phased Amplify Gen 2 workflow skill that orchestrates SOP-driven execution.
plugins/aws-amplify/commands/build.md Adds /aws-amplify:build slash command delegating to the workflow skill.
plugins/aws-amplify/README.md Adds end-user documentation for installing and using the plugin.
plugins/aws-amplify/.mcp.json Adds MCP server configuration intended for AWS SOP retrieval.
plugins/aws-amplify/.claude-plugin/plugin.json Adds the plugin manifest (metadata for marketplace/tooling).
.claude-plugin/marketplace.json Registers aws-amplify in the marketplace registry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aws-amplify/skills/amplify-workflow/SKILL.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/.mcp.json Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .claude-plugin/marketplace.json
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Copilot AI review requested due to automatic review settings February 11, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/CODEOWNERS Outdated
Comment thread plugins/aws-amplify/.mcp.json
Comment thread plugins/aws-amplify/skills/amplify-workflow/SKILL.md Outdated
Copilot AI review requested due to automatic review settings February 11, 2026 09:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aws-amplify/skills/amplify-workflow/SKILL.md Outdated
@must1d must1d requested review from a team as code owners February 11, 2026 11:09
Copilot AI review requested due to automatic review settings February 11, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aws-amplify/commands/build.md Outdated
Copilot AI review requested due to automatic review settings February 11, 2026 11:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aws-amplify/skills/amplify-workflow/SKILL.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/README.md Outdated
Comment thread plugins/aws-amplify/skills/amplify-workflow/SKILL.md Outdated
@scottschreckengaust scottschreckengaust requested review from theagenticguy and removed request for krokoko March 12, 2026 21:38
@hfurkanbozkurt hfurkanbozkurt self-requested a review March 12, 2026 21:41
hfurkanbozkurt
hfurkanbozkurt previously approved these changes Mar 12, 2026
@scoropeza

Copy link
Copy Markdown
Contributor

Code review

All 4 issues from the previous review have been addressed:

  1. Merge conflict resolved (PR is now mergeable)
  2. "Start new conversation" replaced with re-run prerequisite check flow
  3. ## Defaults section added to SKILL.md
  4. AWS CLI check added to prereq-check.sh

One remaining item: the plugin is missing a plugins/aws-amplify/README.md. DESIGN_GUIDELINES requires this file with the following sections:

  • Overview - 1-2 sentence plugin purpose
  • Skills - List of included skills with descriptions
  • MCP Servers - Required servers and what they provide
  • Installation - claude plugin install command
  • Examples - 3-5 concrete usage examples

Keep under 300 lines. See plugins/migration-to-aws/README.md for reference.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Copilot AI review requested due to automatic review settings March 13, 2026 22:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@hfurkanbozkurt hfurkanbozkurt force-pushed the aws-amplify branch 2 times, most recently from 9a95bad to e317434 Compare March 13, 2026 22:26

@scoropeza scoropeza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues addressed, this is approved.

@theagenticguy theagenticguy removed the request for review from scottschreckengaust March 16, 2026 11:35
@hfurkanbozkurt hfurkanbozkurt added this pull request to the merge queue Mar 16, 2026
Merged via the queue into awslabs:main with commit 585ee76 Mar 16, 2026
24 checks passed
@hfurkanbozkurt hfurkanbozkurt deleted the aws-amplify branch March 16, 2026 11:41
icarthick added a commit to icarthick/agent-plugins that referenced this pull request Mar 30, 2026
* upstream/main:
  docs: Add Japanese README (awslabs#106)
  feat(databases-on-aws): add initial Aurora DSQL skill for Databases on AWS Plugin pt. 1 (awslabs#66)
  chore(deps): update github-actions: Bump jdx/mise-action (awslabs#96)
  feat(aws-serverless): Add Amazon API gateway skill (awslabs#94)
  chore(deps): update github-actions: Bump actions/download-artifact (awslabs#93)
  feat(aws-amplify): add AWS Amplify Gen 2 plugin (awslabs#18)
  fix: formatting in CODEOWNERS for amazon-location-service (awslabs#90)
  feat: exlcude generic OpenAI rule for semgrep (awslabs#89)
  feat(tools): add reference integrity, size validation, and skill scaffolding (awslabs#87)
  docs: add aws-serverless plugin documentation to README (awslabs#86)
  feat(migration-to-aws): Migration plugin (awslabs#73)

# Conflicts:
#	.claude-plugin/marketplace.json
#	.github/CODEOWNERS
#	AGENTS.md
#	README.md
Morlej added a commit to Morlej/agent-plugins that referenced this pull request May 15, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
anwesham-lab pushed a commit to Morlej/agent-plugins that referenced this pull request May 26, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Morlej added a commit to Morlej/agent-plugins that referenced this pull request Jun 17, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Morlej added a commit to Morlej/agent-plugins that referenced this pull request Jun 19, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
anwesham-lab pushed a commit to Morlej/agent-plugins that referenced this pull request Jun 22, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Morlej added a commit to Morlej/agent-plugins that referenced this pull request Jun 24, 2026
- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sbbhimji pushed a commit to sbbhimji/agent-plugins that referenced this pull request Jun 30, 2026
…ction, rewrites, and workflow extraction (awslabs#162)

* feat(dsql): enhance query plan explainability with type coercion detection and rewrite references

- Add structured trigger phrases and routing criteria for query plan diagnosis
- Add type coercion index bypass detection (implicit cast compatibility matrix)
- Extend catalog queries with indexed column type retrieval
- Add generic SQL rewrite reference (11 patterns: OR-to-IN, subquery unnesting, etc.)
- Add DSQL-specific rewrite reference (reltuples estimate, split large joins for DP threshold)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat(dsql): extract query plan workflow, add rewrite evals

- Extract Workflow 8 (query plan explainability) from SKILL.md into
  references/query-plan/workflow.md to stay under the 300 LOC limit
- Wire query-rewrites-generic.md and query-rewrites-dsql-specific.md
  into the workflow (Phase 0 load list + Phase 2 evidence gathering)
- Add behavioral evals (query_plan_rewrite_evals.json) covering type
  coercion detection, subquery unnesting, OR-to-IN, GROUP BY pushdown,
  large join splitting, and reltuples estimation
- Add eval results (query_plan_rewrite_eval_results.md) with
  with-skill vs baseline comparison

Validation:
- validate-size.py: 275 lines (good)
- validate-references.py: 0 broken links, 0 new orphans

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: correct markdown link fragments in workflow.md TOC

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* style: apply dprint table formatting

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(dsql): address PR review — split rewrites, positive language, RFC keywords

Review feedback from amaksimo:

- Split query-rewrites-generic.md into 11 individual files under
  query-rewrites/ subdirectory to reduce context consumption
- Split query-rewrites-dsql-specific.md into individual files
- Convert monolithic files to index tables pointing to sub-files
- Fix DATEADD() SQL Server syntax → PostgreSQL NOW() - INTERVAL
- Flip negative language ("Do not apply") to positive ("Skip when")
- Add RFC keywords (MUST, SHOULD, MAY) throughout
- Remove psql fallback from workflow.md (enforce MCP usage)
- Update plan-interpretation.md recommendation template with RFC language
- Make Phase 0 loading explicit: MUST for core refs, SHOULD for rewrites

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(dsql): address PR awslabs#162 review — correctness, references, evals

Correctness fixes (review items 1-5):
- #1: push-computation-to-constant — use NUMERIC column 'amount' to
  avoid integer division non-equivalence
- #2: not-in-to-not-exists — add NULL semantics warning (NOT EXISTS
  does not preserve NOT IN's NULL-propagation; MUST confirm with user)
- awslabs#3/awslabs#4: subquery-unnesting — prefer EXISTS form (true semi-join);
  document uniqueness precondition for JOIN+DISTINCT alternative
- awslabs#5: subquery-unnesting-scalar — add COALESCE(s_count, 0) for
  COUNT/SUM (LEFT JOIN returns NULL, scalar returns 0)

Dangling reference fixes (review items 6-8):
- awslabs#6: workflow.md trigger table — "Phase 5" → reassessment re-entry
- awslabs#7: Replace all "implicit cast compatibility matrix" references
  with "pg_amop query in catalog-queries.md"
- awslabs#8: plan-interpretation.md L202 — fix cast-vs-operator contradiction

Structural fixes (review items 9-14, 24):
- awslabs#9: Hedge "integer family" claim with "at time of writing" + verify
- awslabs#10: amopmethod=10003 — add provenance comment and verification SQL
- awslabs#11: catalog-queries.md TOC — add 3 missing sections
- awslabs#12: plan-interpretation.md TOC — add Type Coercion section
- awslabs#13: SKILL.md — explicitly delegate routing to workflow.md
- awslabs#24: workflow.md — remove em dashes from headings for clean anchors

Other fixes (review items 21-23):
- awslabs#21: reltuples-estimate — add staleness warning (MUST warn user)
- awslabs#22: catalog-queries — add safe_query.build() note for placeholders
- awslabs#23: "Skip when" → "SHOULD skip when" in all rewrite files

Eval improvements (review items 14, 16):
- awslabs#14: README — add query_plan_rewrite_evals to directory tree and
  eval section
- awslabs#16: Add evals 206-210 covering LEFT JOIN, computation push, NOT IN
  with NULL warning, nested UNION ALL, and negative case (OR across
  different columns)
- awslabs#7 (eval): Update eval 201 expectation — pg_amop instead of matrix

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(dsql): address remaining PR awslabs#162 review items

- awslabs#17: Downgrade eval results to qualitative comparison, record model
  and version, note n=1 and recommend n>=3 for production confidence
- awslabs#18: SKILL.md is 281 lines (will update PR body)
- awslabs#20: Strengthen awsknowledge fallback to MUST — refuse fallback when
  recommendation depends on exact limit value
- awslabs#21: Already addressed in prior commit (reltuples staleness)
- awslabs#15: Document manual-only status and future Python converter direction
  (per anwesham-lab's suggestion for deterministic rewrites)
- awslabs#19: MCP mirror PR noted as follow-up in PR body

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(dsql): address self-review findings — links, inclusive language, evals

- Revert broken relative links in SKILL.md (mcp/.mcp.json, scripts/)
  back to correct ../../ paths
- Rename blacklisted_customers → excluded_customers and blacklist →
  exclusion_list for inclusive language compliance
- Fix stale 'implicit cast compatibility matrix' → pg_amop in eval
  results
- Add eval results for 206–210 (LEFT JOIN, computation push, NOT IN
  NULL warning, nested UNION ALL, negative OR case)
- Include hooks.json update

* fix: remove stray conflict marker in evals README

* style: apply dprint table formatting to eval results

* fix(dsql): wire workflow.md and rewrite indexes into SKILL.md

Addresses amaksimo's review comment: after rebase onto main, the
Workflow 9 section lost its link to workflow.md and the rewrite index
files, making all 16 new query-plan files unreachable orphans.

- Add workflow.md as the entry gate in the reference table
- Add query-rewrites-generic.md and query-rewrites-dsql-specific.md
- Update Workflow 9 section to load workflow.md instead of listing
  the 4 Phase-0 files directly (workflow.md handles that routing)

* fix(dsql): address review findings awslabs#4, awslabs#5, awslabs#7, awslabs#8, awslabs#9

- awslabs#4: COALESCE rule in subquery-unnesting-scalar.md restricted to
  COUNT only; SUM/MAX/MIN return NULL on empty sets in both forms
- awslabs#5: verify-comment in catalog-queries.md changed from
  amname='btree' to amname='btree_index' (DSQL uses btree_index AM)
- awslabs#7: workflow.md context disambiguation removes psql fallback offer,
  now says no MCP means no plan capture (consistent with Safety)
- awslabs#8: split-large-joins.md example expanded from 7 to 11 tables,
  exceeding the stated DP threshold of 10; CTEs project explicit cols
- awslabs#9: plan-interpretation.md recommendation template changed ::float
  to ::integer (only integer-family cross-type operators registered)

* fix(dsql): correct safe_query substitution guidance in catalog-queries

Lift the substitution rule to the file preamble with per-position
guidance: identifier positions (FROM, GROUP BY) use ident(); string-
literal positions (WHERE = '{schema}', IN ('{table}')) use allow()
or regex(). The prior note incorrectly prescribed ident() for all
positions, which would produce invalid SQL in WHERE clauses.

* refactor(dsql): merge in-subquery-to-exists into subquery-unnesting-uncorrelated

Delete redundant in-subquery-to-exists.md — same input shape and same
rewrite as subquery-unnesting-uncorrelated.md. Merge the 'large result
set' trigger and 'small static set' skip condition into the canonical
file. Update index and eval 200 to route exclusively there.

* style: apply dprint table formatting to workflow.md

* fix(dsql): address merge-blocking review findings #1-awslabs#4

- #1: Strip surrounding quotes from all placeholders in catalog-queries
  so safe_query helpers (which emit their own quotes) don't double-quote.
  Add worked safe_query.build() example to preamble.
- #2: DP threshold changed from 10 to 8 (validated: SHOW
  join_collapse_limit = 8 on live DSQL). Agent now instructed to SHOW
  the value rather than hardcoding.
- awslabs#3: Remove pg_stat_user_tables.last_analyze cross-check (DSQL never
  populates it). Guard reltuples with GREATEST(..., 0) for the -1
  sentinel on never-analyzed tables.
- awslabs#4: Fix '11 generic' to '10 generic' in SKILL.md reference table.

* feat(dsql): add blog learnings — filter model, DPU, CTE rewrite

- Add Three-Layer Filter Model (Index Cond / Storage Filter / Query
  Processor Filter) with optimization table to plan-interpretation.md
- Add Fixing Storage Lookups guidance (INCLUDE columns) with example
- Add Cost Number Interpretation (startup ~100 is normal in DSQL)
- Add DPU Interpretation (Read DPU as primary signal, optimization loop)
- Add CTE late materialization as DSQL-specific rewrite pattern
  (defer Storage Lookups past LIMIT)
- Update workflow.md Phase 1: recommend plain EXPLAIN first for
  expensive queries before EXPLAIN ANALYZE VERBOSE

* chore: bump databases-on-aws plugin version to 1.4.0

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants