Feature/auth methods#14
Open
dacort wants to merge 18 commits into
Open
Conversation
lmouhib
force-pushed
the
feature/auth-methods
branch
from
9ce7108 to
eeb6ccf
Compare
dacort
commented
Apr 24, 2023
Contributor
Author
dacort
left a comment
dacort
left a comment
There was a problem hiding this comment.
A few initial comments.
Comment on lines
+5
to
+6
| AWS_ACCESS_KEY_ID: ${{ vars.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ vars.AWS_SECRET_ACCESS_KEY }} |
Contributor
Author
There was a problem hiding this comment.
What are these used for?
Contributor
There was a problem hiding this comment.
These are used for unit tests, they allow to init the boto3 sessions. They contain dummy values.
Comment on lines
+156
to
+159
| @click.option( | ||
| "--profile", | ||
| help="The AWS profile to use for bootstraping the environment.", | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
The run command errors out as this is not passed in as an argument in def run() below.
conventions fix Co-authored-by: Damon P. Cortesi <d.lifehacker@gmail.com>
Lint Co-authored-by: Damon P. Cortesi <d.lifehacker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a new
--profileoption to bootstrap to allow you to specify the AWS profile you want to use.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.