md5 error checking

Author: DmitriyMusatkin

crt/aws-c-s3

@@ -30,7 +30,9 @@ public enum ChecksumAlgorithm {
 
     XXHASH3(8),
 
-    XXHASH128(9);
+    XXHASH128(9),
+
+    MD5(10);
 
     ChecksumAlgorithm(int nativeValue) {
         this.nativeValue = nativeValue;
@@ -61,6 +63,7 @@ private static Map<Integer, ChecksumAlgorithm> buildEnumMapping() {
         enumMapping.put(XXHASH64.getNativeValue(), XXHASH64);
         enumMapping.put(XXHASH3.getNativeValue(), XXHASH3);
         enumMapping.put(XXHASH128.getNativeValue(), XXHASH128);
+        enumMapping.put(MD5.getNativeValue(), MD5);
         return enumMapping;
     }
 

src/main/java/software/amazon/awssdk/crt/s3/ChecksumAlgorithm.java

@@ -168,6 +168,12 @@ public S3MetaRequest makeMetaRequest(S3MetaRequestOptions options) {
             throw new IllegalArgumentException("S3Client.makeMetaRequest has invalid options; Operation name must be set for MetaRequestType.DEFAULT.");
         }
 
+        if (options.getChecksumConfig() != null && options.getChecksumAlgorithm() == ChecksumAlgorithm.MD5) {
+            Log.log(Log.LogLevel.Error, Log.LogSubject.S3Client,
+                    "S3Client.makeMetaRequest has invalid options; MD5 not supported as checksum algorithm.");
+            throw new IllegalArgumentException("S3Client.makeMetaRequest has invalid options; MD5 not supported as checksum algorithm.");
+        }
+
         S3MetaRequest metaRequest = new S3MetaRequest();
         S3MetaRequestResponseHandlerNativeAdapter responseHandlerNativeAdapter = new S3MetaRequestResponseHandlerNativeAdapter(
                 options.getResponseHandler());

src/main/java/software/amazon/awssdk/crt/s3/S3Client.java

@@ -307,6 +307,39 @@ public void testS3ClientCreateDestroyHttpProxyEnvironmentVariableSetting() {
         }
     }
 
+    @Test
+    public void testS3ClientCreateMD5MetaRequest() {
+        skipIfAndroid();
+        skipIfNetworkUnavailable();
+
+        S3ClientOptions clientOptions = new S3ClientOptions().withRegion(REGION)
+                .withComputeContentMd5(true)
+                .withMemoryLimitInBytes(5L * 1024 * 1024 * 1024);
+        try (S3Client client = createS3Client(clientOptions)) {
+            S3MetaRequestResponseHandler responseHandler = new S3MetaRequestResponseHandler() {
+                @Override
+                public int onResponseBody(ByteBuffer bodyBytesIn, long objectRangeStart, long objectRangeEnd) {
+                    return 0;
+                }
+
+                @Override
+                public void onFinished(S3FinishedResponseContext context) {
+                }
+            };
+
+            HttpHeader[] headers = { new HttpHeader("Host", ENDPOINT) };
+            HttpRequest httpRequest = new HttpRequest("GET", PRE_EXIST_1MB_PATH, headers, null);
+
+            S3MetaRequestOptions metaRequestOptions = new S3MetaRequestOptions()
+                    .withMetaRequestType(MetaRequestType.GET_OBJECT)
+                    .withChecksumAlgorithm(ChecksumAlgorithm.MD5)
+                    .withHttpRequest(httpRequest)
+                    .withResponseHandler(responseHandler);
+
+            Assert.assertThrows(IllegalArgumentException.class, () -> { client.makeMetaRequest(metaRequestOptions); });
+        }
+    }
+
     @Test
     public void testS3Get() {
         skipIfAndroid();
@@ -1385,13 +1418,29 @@ public void onFinished(S3FinishedResponseContext context) {
     }
 
     @Test
-    public void testS3PutTrailerChecksums() throws Exception {
+    public void testS3PutTrailerChecksumsCRC64() throws Exception {
         skipIfAndroid();
         skipIfNetworkUnavailable();
         Assume.assumeTrue(hasAwsCredentials());
         testS3RoundTripWithChecksumHelper(ChecksumAlgorithm.CRC64NVME, ChecksumLocation.TRAILER, false, false);
     }
 
+    @Test
+    public void testS3PutTrailerChecksumsSHA512() throws Exception {
+        skipIfAndroid();
+        skipIfNetworkUnavailable();
+        Assume.assumeTrue(hasAwsCredentials());
+        testS3RoundTripWithChecksumHelper(ChecksumAlgorithm.SHA512, ChecksumLocation.TRAILER, false, false);
+    }
+
+    @Test
+    public void testS3PutTrailerChecksumsXXHASH3_64() throws Exception {
+        skipIfAndroid();
+        skipIfNetworkUnavailable();
+        Assume.assumeTrue(hasAwsCredentials());
+        testS3RoundTripWithChecksumHelper(ChecksumAlgorithm.XXHASH3, ChecksumLocation.TRAILER, false, false);
+    }
+
     @Test
     public void testS3PutHeaderChecksums() throws Exception {
         skipIfAndroid();