testing

Author: azkrishpy

src/native/http_request_utils.c

@@ -94,38 +94,29 @@ static int s_aws_input_stream_read(struct aws_input_stream *stream, struct aws_b
     }
 
     size_t out_remaining = dest->capacity - dest->len;
-    int result = AWS_OP_SUCCESS;
+    size_t chunk_size = 1024;
     /* Newer updates allow part sizes up to 5GB. Since number of bytes required for a 5GB part is
     greater than INT_MAX, it would cause a bug where the java does not allocate memory and return a null buffer
-    since Java natively does not support direct allocation of buffers of capacity > Integer.MAX_VALUE. */
-    while (out_remaining > 0) {
-        size_t chunk_size = INT_MAX;
-        if (out_remaining <= chunk_size) {
-            chunk_size = out_remaining;
-        }
+    since Java natively does not support direct allocation of buffers of capacity > Integer.MAX_VALUE. 
+    Since C handles recursively calling for more data, we read up to chunk size or out_remaining (whichever is lower)
+    and return the C. */
+    if (out_remaining <= chunk_size) {
+        chunk_size = out_remaining;
+    }
 
-        jobject direct_buffer = aws_jni_direct_byte_buffer_from_raw_ptr(env, dest->buffer + dest->len, chunk_size);
+    jobject direct_buffer = aws_jni_direct_byte_buffer_from_raw_ptr(env, dest->buffer + dest->len, chunk_size);
 
-        impl->body_done = (*env)->CallBooleanMethod(
-            env, impl->http_request_body_stream, http_request_body_stream_properties.send_outgoing_body, direct_buffer);
-
-        if (aws_jni_check_and_clear_exception(env)) {
-            result = aws_raise_error(AWS_ERROR_HTTP_CALLBACK_FAILURE);
-            (*env)->DeleteLocalRef(env, direct_buffer);
-            break;
-        }
-
-        size_t amt_written = aws_jni_byte_buffer_get_position(env, direct_buffer);
-        if (amt_written == 0) {
-            (*env)->DeleteLocalRef(env, direct_buffer);
-            break;
-        }
-        dest->len += amt_written;
-        out_remaining -= amt_written;
+    impl->body_done = (*env)->CallBooleanMethod(
+        env, impl->http_request_body_stream, http_request_body_stream_properties.send_outgoing_body, direct_buffer);
 
+    if (aws_jni_check_and_clear_exception(env)) {
+        result = aws_raise_error(AWS_ERROR_HTTP_CALLBACK_FAILURE);
         (*env)->DeleteLocalRef(env, direct_buffer);
+        break;
     }
 
+    (*env)->DeleteLocalRef(env, direct_buffer);
+
     aws_jni_release_thread_env(impl->jvm, &jvm_env_context);
     /********** JNI ENV RELEASE **********/
 

src/test/java/software/amazon/awssdk/crt/test/S3ClientTest.java

@@ -1870,7 +1870,7 @@ public void testS3PutLargePartViaStream() {
         skipIfNetworkUnavailable();
         Assume.assumeTrue(hasAwsCredentials());
 
-        long contentLength = 3L * 1024 * 1024 * 1024;
+        long contentLength = 3L * 1024;
 
         S3ClientOptions clientOptions = new S3ClientOptions()
                 .withRegion(REGION)