Fix Windows CI passing when tests fail (#953)

Co-authored-by: Krish <>

Author: azkrishpy

.builder/actions/localhost_test.py

@@ -4,7 +4,7 @@
 import sys
 import time
 import os
-
+import platform
 
 class LocalhostTest(Builder.Action):
 
@@ -16,20 +16,24 @@ def start(self, env):
         if result.returncode != 0:
             print("Could not start a virtual environment. The localhost integration tests will fail.", file=sys.stderr)
             return
-        
-        python = os.path.join(venv_path, "bin", "python")
-        
+
+        # Platform-specific
+        if platform.system() == 'Windows':
+            python = os.path.join(venv_path, "Scripts", "python.exe")
+        else:
+            python = os.path.join(venv_path, "bin", "python")
+
         result = env.shell.exec(python, '-m', 'pip', 'install', 'h11', 'h2', 'trio')
         if result.returncode != 0:
             print("Could not install python HTTP dependencies. The localhost integration tests will fail.", file=sys.stderr)
             return
-        
+
         server_dir = os.path.join(env.root_dir,'crt','aws-c-http','tests','mock_server')
-        
+
         p1 = subprocess.Popen([python, "h2tls_mock_server.py"], cwd=server_dir)
         p2 = subprocess.Popen([python, "h2non_tls_server.py"], cwd=server_dir)
         p3 = subprocess.Popen([python, "h11mock_server.py"], cwd=server_dir)
-        
+
         # Wait for servers to be ready
         ports = [3443, 3280, 8082, 8081]
         for port in ports:

src/test/java/software/amazon/awssdk/crt/test/FailFastListener.java

@@ -6,6 +6,8 @@
 public class FailFastListener extends RunListener {
     public void testFailure(Failure failure) throws Exception {
         System.err.println("FAILURE: " + failure);
-        System.exit(-1);
+        // Previously we used a negative code but caused CI to pass,
+        // for unknown reasons, even when tests failed on Windows.
+        System.exit(1);
     }
 }