Add abortStream method to Http1StreamManager and ensure streams are released to connection pool - #1001
Open
alextwoods wants to merge 3 commits into
Open
Add abortStream method to Http1StreamManager and ensure streams are released to connection pool#1001alextwoods wants to merge 3 commits into
alextwoods wants to merge 3 commits into
Conversation
…eleased to pool in all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a caller (e.g., the SDK's timeout handler) calls stream.cancel() + stream.close(). (See Java SDK PR #6919 that introduces a new regression) on a stream obtained from Http1StreamManager, the connection slot is permanently leaked from the pool. This happens because Http1StreamManager only releases connections inside its onResponseComplete wrapper, and cancel() + close() can prevent that callback from being delivered — either because the native handle is released before the callback fires, or because the stream was closed before activation made it a no-op.
Under load with aggressive timeouts (e.g., after a network blip), this quickly exhausts the entire pool, causing 100% request failures with no recovery until process restart.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.