Skip to content

pre-commit fixups#15

Open
matthew-l-weber wants to merge 1 commit into
awslabs:mainfrom
matthew-l-weber:mlw/pre-commit
Open

pre-commit fixups#15
matthew-l-weber wants to merge 1 commit into
awslabs:mainfrom
matthew-l-weber:mlw/pre-commit

Conversation

@matthew-l-weber
Copy link
Copy Markdown

@matthew-l-weber matthew-l-weber commented Feb 8, 2026 •
edited
Loading

🧠 Pull Request

Changes

  • Add mention of folders assumed to be present for volume map (which fails if they're not present)
  • Add test for working Docker
  • Adds end of file new lines
  • Drops comments in json files (json doesn't have a comment syntax)
  • Added shellcheck ignores on intentional syntax

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Why

Cleans up pre-commit to pass on default project files.

Checklist

  • Jest unit tests (as needed)
  • Integration tests (as needed)
  • Storybook stories (as needed)
  • Run storybook locally
  • Acceptance Criteria met
  • Screenshot added to Summary for UI ticket
  • Check test coverage of new or updated components (Reduce Banlist)

Note folder and Docker assumptions
2eca939 
- Update readme with steps to help user have
  success with volume mounts
- Note a quick test for Docker working
- pre-commit fixups
  - end of file new lines
  - no comments in json files
  - shellcheck ignores on intentional syntax

Signed-off-by: Matthew Weber <matthew.l.weber@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@matthew-l-weber